Repository navigation
Merged
Conversation
Contributor
|
@apasel422 legitimate failure: The size_hint API changed, the lower bound is no longer an Option (because None is semantically equivalent to 0, for the lower bound, always) |
Author
|
@cmr: Fixed. |
bors
added a commit
that referenced
this pull request
Jul 8, 2013
This can be useful for inserting debugging code at different steps in an iterator pipeline.
ghost
deleted the
peek
branch
July 8, 2013 19:52
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 3, 2021
Rustup I'll write some TODOs later. This time I'll need a review for this Rustup r? `@ghost` (for now) changelog: none
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7677: More enum matching r=yoshuawuyts a=jDomantas * Renamed existing `generate_enum_match_method` to `generate_enum_is_variant` * Added two similar assists to generate `into_` and `as_` methods. * Made all of them general enough to work on record and tuple variants too. For `as_` method generation there's room to improve: * Right now it always returns `Option<&Field>`, even though `Option<Field>` would be nicer when `Field: Copy`. I don't know how to check if the field type implements `Copy`. If given suggestions I could try to fix this in a follow-up pr. * `&String` could be replaced with `&str`, `&Box<_>` with `&_`, and probably some more. I don't know what would be a good way to do that. Closes rust-lang#7604 Co-authored-by: Domantas Jadenkus <djadenkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful for inserting debugging code at different steps in an iterator pipeline.