fix a couple of clippy findings - #75270

Merged

bors merged 17 commits into

rust-lang:masterfrom

matthiaskrgr:clippy_aug_1

Aug 8, 2020

Commits on Aug 7, 2020

fix clippy::expect_fun_call: use unwrap_or_else to prevent panic message from always being evaluated
matthiaskrgr
committed
3ef8c72
fix clippy::filter_next: use .find(..) instead of .filter(..).next()
matthiaskrgr
committed
8bc1f91
fix clippy::iter_next_slice: use .get(0) instead of .iter().next()
matthiaskrgr
committed
fca81fa
fix clippy::map_identity: remove redundant .map(|x| x) call
matthiaskrgr
committed
fb975cd
fix clippy::redundant_clone: remove redundant clones
matthiaskrgr
committed
27bb689
fix clippy::redundant_pattern_matching: use .is_some() instead of if let Some(_) = ..
matthiaskrgr
committed
09e29e7
fix clippy::single_char_pattern: use char instead of string single-char pattern
matthiaskrgr
committed
f3ec5be
fix clippy::unit_arg: make it explicit that Ok(()) is being returned
matthiaskrgr
committed
a1c2212
fix clippy::unnecessary_mut_passed: function arg is not required to be mutable
matthiaskrgr
committed
f6b1857
fix clippy::unneeded_wildcard_pattern: remove redundant wildcard pattern
matthiaskrgr
committed
eccc2fe
fix clippy::len_zero: use is_empty() instead of comparing .len() to zero
matthiaskrgr
committed
057730c
fix clippy::redundant_closure: remove redundant closures and call functions directly
matthiaskrgr
committed
f95cfe5
fix clippy::while_let_loop: use while let{} instead of loop { if ... break; }
matthiaskrgr
committed
ea9ccfa
fix clippy::into_iter_on_ref: use .iter() instead of into_iter() on references.
matthiaskrgr
committed
4ba1a19
fix clippy::map_clone: use .cloned() instead of .map(|x| x.clone())
matthiaskrgr
committed
15dcda3
fix clippy::clone_on_copy: don't clone types that are copy
matthiaskrgr
committed
ff692ab
fix clippy::needless_return: remove unneeded return statements
matthiaskrgr
committed
a605e51

Navigation Menu

Uh oh!

fix a couple of clippy findings - #75270

fix a couple of clippy findings#75270
bors merged 17 commits into
rust-lang:masterfrom
matthiaskrgr:clippy_aug_1

Commits on Aug 7, 2020

fix clippy::expect_fun_call: use unwrap_or_else to prevent panic message from always being evaluated

fix clippy::filter_next: use .find(..) instead of .filter(..).next()

fix clippy::iter_next_slice: use .get(0) instead of .iter().next()

fix clippy::map_identity: remove redundant .map(|x| x) call

fix clippy::redundant_clone: remove redundant clones

fix clippy::redundant_pattern_matching: use .is_some() instead of if let Some(_) = ..

fix clippy::single_char_pattern: use char instead of string single-char pattern

fix clippy::unit_arg: make it explicit that Ok(()) is being returned

fix clippy::unnecessary_mut_passed: function arg is not required to be mutable

fix clippy::unneeded_wildcard_pattern: remove redundant wildcard pattern

fix clippy::len_zero: use is_empty() instead of comparing .len() to zero

fix clippy::redundant_closure: remove redundant closures and call functions directly

fix clippy::while_let_loop: use while let{} instead of loop { if ... break; }

fix clippy::into_iter_on_ref: use .iter() instead of into_iter() on references.

fix clippy::map_clone: use .cloned() instead of .map(|x| x.clone())

fix clippy::clone_on_copy: don't clone types that are copy

fix clippy::needless_return: remove unneeded return statements