Repository navigation
Conversation
Contributor
|
Landing with #7479. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 3, 2021
…_effect, r=flip1995 Don't report function calls as unnecessary operation if used in array index Attempts to fix: rust-lang#7412 changelog: Don't report function calls used in indexing as unnecessary operation. [`unnecessary_operation`]
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7657: utf8 r=matklad a=matklad - Prepare for utf-8 offsets - reduce code duplication in tests - Make utf8 default, implement utf16 in terms of it - Make it easy to add additional context for offset conversion - Implement utf8 offsets closes rust-lang#7453 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler reported that as a warning while building, and from looking at it quickly it seems to be indeed unused and overwritten two lines below. I hope I'm not missing something obvious though.