Skip to content

Add RefCell::take - #71398

Merged
bors merged 3 commits into
rust-lang:masterfrom
ThinkChaos:feat_refcell_take
May 3, 2020
Merged

Add RefCell::take#71398
bors merged 3 commits into
rust-lang:masterfrom
ThinkChaos:feat_refcell_take

Conversation

@ThinkChaos

@ThinkChaos ThinkChaos commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Add RefCell::take to match Cell and Option.
I also changed a couple of calls to .replace to .take.

Tracking issue is #71395.

This is my first contribution, please tell me if there's anything I could improve, thanks!

@ThinkChaos
ThinkChaos force-pushed the feat_refcell_take branch 2 times, most recently from 85ad89d to 0fb7907 Compare April 21, 2020 20:03
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2020
@therealprof

therealprof commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

I don't think we should have the #[inline] attributes added here (unless there's a good reason to do it?) but the rest looks very good and useful to me.

@ThinkChaos

ThinkChaos commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

I removed the inline attributes :)

@bors

bors commented Apr 25, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #71439) made this pull request unmergeable. Please resolve the merge conflicts.

@ThinkChaos
Add RefCell::take
f121f09 
In the same vein as `Cell::take` and `Option::take`.
@ThinkChaos
Use Cell::take in a couple places
4ea83bf
LukasKalbertodt
LukasKalbertodt suggested changes May 2, 2020
View reviewed changes

@LukasKalbertodt LukasKalbertodt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and please excuse my late response. Looks like a useful addition! Just one inline comment.

As this is a tiny feature, I think the doc example is sufficient as test. The PR adding Cell::take (#39287) also didn't add any tests.

Comment thread src/libcore/cell.rs
@ThinkChaos

ThinkChaos commented May 3, 2020

Copy link
Copy Markdown
Contributor Author

No worries, thanks for the review!

I copied the docs from RefCell::replace.

@LukasKalbertodt

LukasKalbertodt commented May 3, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4a79424 has been approved by LukasKalbertodt

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2020
@ThinkChaos ThinkChaos mentioned this pull request May 3, 2020
Closed
1 of 2 tasks
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 3, 2020
@Dylan-DPC
Rollup merge of rust-lang#71398 - ThinkChaos:feat_refcell_take, r=Luk…
d0bbd25 
…asKalbertodt

Add `RefCell::take`

Add `RefCell::take` to match `Cell` and `Option`.
I also changed a couple of calls to `.replace` to `.take`.

Tracking issue is rust-lang#71395.

This is my first contribution, please tell me if there's anything I could improve, thanks!
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 3, 2020
Closed
@bors

ghost commented May 3, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4a79424 with merge bba798dd3eaf4c68b9f1ef3cb223dbacf9f764c1...

This was referenced May 3, 2020
Closed
Merged
@Dylan-DPC-zz

ghost commented May 3, 2020

Copy link
Copy Markdown

included in rollup, yielding

@bors retry

@bors

ghost commented May 3, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #71853) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 3, 2020
@bors
bors merged commit 6f5de87 into rust-lang:master May 3, 2020
@ThinkChaos
ThinkChaos deleted the feat_refcell_take branch November 22, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LukasKalbertodt LukasKalbertodt

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ThinkChaos @therealprof @bors @LukasKalbertodt @Dylan-DPC-zz @JohnTitor