Skip to content

Add long error explaination for E0666 - #65855

Merged
bors merged 2 commits into
rust-lang:masterfrom
ObsidianMinor:extended_error/E0666
Oct 27, 2019
Merged

bors merged 2 commits into
rust-lang:masterfrom
ObsidianMinor:extended_error/E0666

Conversation

@ObsidianMinor

Copy link
Copy Markdown
Contributor

In the spirit of the month of spooks, here's a long explanation for E0666 for #61137.

@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2019

@varkor varkor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with word change.

Comment thread src/librustc_passes/error_codes.rs Outdated
Co-Authored-By: varkor <github@varkor.com>
@varkor

varkor commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+ rollup

@bors

bors commented Oct 26, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 16547f5 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
… r=varkor

Add long error explaination for E0666

In the spirit of the month of spooks, here's a long explanation for E0666 for rust-lang#61137.
bors added a commit that referenced this pull request Oct 27, 2019
Rollup of 6 pull requests

Successful merges:

 - #65566 (Use heuristics to suggest assignment)
 - #65738 (Coherence should allow fundamental types to impl traits when they are local)
 - #65777 (Don't ICE for completely unexpandable `impl Trait` types)
 - #65834 (Remove lint callback from driver)
 - #65839 (Clean up `check_consts` now that new promotion pass is implemented)
 - #65855 (Add long error explaination for E0666)

Failed merges:

r? @ghost
@bors
bors merged commit 16547f5 into rust-lang:master Oct 27, 2019
@JohnTitor JohnTitor mentioned this pull request Nov 16, 2019
98 of 100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants