Skip to content

Don't ICE when relating const type args - #60277

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:relate-ice
May 7, 2019
Merged

bors merged 1 commit into
rust-lang:masterfrom
estebank:relate-ice

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix #60263.

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2019
Comment thread src/librustc/ty/relate.rs Outdated
@varkor varkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2019
@varkor

varkor commented May 2, 2019

Copy link
Copy Markdown
Contributor

Now that #59008 has been merged, it should be sufficient just to add the regression test.

@estebank

estebank commented May 2, 2019

Copy link
Copy Markdown
Contributor Author

@varkor cool! I'll do that soonish.

@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2019
@varkor

varkor commented May 6, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 6, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7508086 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2019
bors added a commit that referenced this pull request May 7, 2019
Don't ICE when relating const type args

Fix #60263.

r? @varkor
@bors

bors commented May 7, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7508086 with merge 17dba3b...

@bors

bors commented May 7, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: varkor
Pushing 17dba3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2019
@bors
bors merged commit 7508086 into rust-lang:master May 7, 2019
@varkor varkor added the F-const_generics `#![feature(const_generics)]` label Oct 19, 2019
@estebank
estebank deleted the relate-ice branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-const_generics `#![feature(const_generics)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Const generic ICE without feature specified

4 participants