Skip to content

Remove a stray new operator in rust_task.h - #6025

Closed
alexcrichton wants to merge 1 commit into
rust-lang:incomingfrom
alexcrichton:issue-2697
Closed

alexcrichton wants to merge 1 commit into
rust-lang:incomingfrom
alexcrichton:issue-2697

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Closes #2697

I guess all of the uses weren't around any more, because everything continued to compile (at least on OSX). If bors doesn't like it for another platform I can try to track it down as well.

bors added a commit that referenced this pull request Apr 23, 2013
Closes #2697

I guess all of the uses weren't around any more, because everything continued to compile (at least on OSX). If bors doesn't like it for another platform I can try to track it down as well.
@bors bors closed this Apr 23, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 24, 2020
…p1995

Extend invalid_atomic_ordering for compare_exchange{,_weak} and fetch_update

changelog: The invalid_atomic_ordering lint can now detect misuse of `compare_exchange`, `compare_exchange_weak`, and `fetch_update`.

---

I was surprised not to find an issue or existing support here, since these are the functions which are always hardest to get the ordering right on for me (as the allowed orderings for `fail` depend on the `success` parameter).

I believe this lint now covers all atomic methods which care about their ordering now, but I could be wrong.

Hopefully I didn't forget to do anything for the PR!
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
6025: Use `log::error!` in a few more places r=jonas-schievink a=jonas-schievink



Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants