Skip to content

[beta] Process backports - #50708

Merged
bors merged 2 commits into
rust-lang:betafrom
emilyalbini:beta-backports
May 13, 2018
Merged

bors merged 2 commits into
rust-lang:betafrom
emilyalbini:beta-backports

Conversation

@emilyalbini

@emilyalbini emilyalbini commented May 13, 2018 •

Copy link
Copy Markdown
Member

r? @alexcrichton

eddyb and others added 2 commits May 13, 2018 16:20
If check_expr_struct_fields fails, do not continue to record update.
If we continue to record update, the struct may cause us to ICE later
on indexing a field that may or may not exist.
@rust-highfive

Copy link
Copy Markdown
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2018
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Thanks @pietroalbini!

@bors

bors commented May 13, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 7041b65 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2018
@emilyalbini

Copy link
Copy Markdown
Member Author

@bors p=1 (beta backport)

@bors

bors commented May 13, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7041b65 with merge 5d261a0...

bors added a commit that referenced this pull request May 13, 2018
[beta] Process backports

* #50622: rustc: leave space for fields of uninhabited types to allow partial initialization.
* #50643: typeck: Fix ICE with struct update syntax

r? @alexcrichton
@bors

bors commented May 13, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5d261a0 to beta...

@bors
bors merged commit 7041b65 into rust-lang:beta May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants