Repository navigation
Fix some E-needstest issues. - #45020
Conversation
Also ignore `attr-on-trait` test on stage-1 to keep `./x.py test --stage 1` successful. Fixes rust-lang#30355. Fixes rust-lang#33241. Fixes rust-lang#36400. Fixes rust-lang#37887. Fixes rust-lang#44578.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
r=me after verifying comment.
| // except according to those terms. | ||
|
|
||
| // aux-build:attr-on-trait.rs | ||
| // ignore-stage1 |
There was a problem hiding this comment.
This is the only test that fails on my machine (x86_64-unknown-linux-gnu with ./x.py test --stage 1), and because it is in run-pass-fulldeps, running it only in stage 2 doesn't seem a problem, because other tests in this directory are ignored on stage 1.
| fn any<T>() -> T { unreachable!() } | ||
|
|
||
| #[rustc_error] | ||
| fn main() { //~ ERROR compilation successful |
There was a problem hiding this comment.
Can you, instead of forcing the failure, make a run-pass test?
There was a problem hiding this comment.
This test panics when running, because of the unreachable!().
Do you want me to move it to run-fail?
shepmaster
added
the
S-waiting-on-author
|
@bors: r+ Thanks! |
|
📌 Commit 7428806 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
6 participants
Also ignore
attr-on-traittest on stage-1 to keep./x.py test --stage 1successful.Fixes #30355.
Fixes #33241.
Fixes #36400.
Fixes #37887.
Fixes #44578.