Improve placement of use suggestions

[oli-obk]

r? @nrc

cc @estebank @Mark-Simulacrum

fixes #42835
fixes #42548
fixes #43769

[estebank]

Love it! The new locations are exactly where they should be. The only wart I see is that by applying these suggestions without any smarts the resulting output would be the following:

use a::A;
struct S;

I don't think we should change the compiler output, I think clients could perform local reformatting to comply with rustfmt instead.

[estebank]

Space between UseError and {?

[estebank]

Isn't the following slightly easier to follow?

    fn visit_mod(&mut self,
                 module: &'tcx ast::Mod,
                 _: Span,
                 _: &[ast::Attribute],
                 node_id: NodeId) {

[oli-obk]

Rustfmt has my version as the new style and I prefer it, too, but I can change it to the other style to fit more into what's still more prominent in rustc.

[oli-obk]

The only wart I see is that by applying these suggestions without any smarts the resulting output would be the following:

use a::A;
struct S;

I don't think we should change the compiler output, I think clients could perform local reformatting to comply with rustfmt instead.

I'm confused... so you want the final output to be use a::A;struct S;?

[estebank]

I'd want the final output to be

use a::A;

struct S;

But wouldn't change rustc for it, as it makes the cli output worse.

[oli-obk]

But wouldn't change rustc for it, as it makes the cli output worse.

Oh I already have a hack that makes sure the cli is fine ;) Adding another newline to the suggestion output in case the following item is not a use would definitely be possible.

[nrc]

@bors: r+

[bors]

📌 Commit 8f56322 has been approved by nrc

[bors]

⌛ Testing commit 8f56322 with merge 06bf94a...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 06bf94a to master...