Skip to content

Add the -s flag to the suggested rustup invocation - #23315

Closed
ghost wants to merge 1 commit into
masterfrom
rustup-curl-silent-flag
Closed

ghost wants to merge 1 commit into
masterfrom
rustup-curl-silent-flag

Conversation

@ghost

@ghost ghost commented Mar 12, 2015

Copy link
Copy Markdown

curl's progress meter would otherwise interfere with sudo's password prompt.

curl's progress meter would otherwise interfere with sudo's password prompt.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@ghost

ghost commented Mar 12, 2015

Copy link
Copy Markdown
Author

Here's what I'm talking about:

$ curl -L https://static.rust-lang.org/rustup.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13083  100 13083    0     0  74812      0 --:--:-- --:--:-- --:--:-- 75189Password:

See the Password prompt at the end? I didn't, for about 20 seconds. :-)

@brson

brson commented Mar 13, 2015

Copy link
Copy Markdown
Contributor

I know this is unrelated, but do you mind adding -sf, not just -s?

-f produces an error if the page isn't found, and sending 404 garbage through a sudo shell is bad.

@ghost

ghost commented Mar 13, 2015

Copy link
Copy Markdown
Author

As I was editing the file from GitHub's UI, I ended up creating the branch in the official rust-lang repo. Closing this PR to reopen with the right branch.

@ghost ghost closed this Mar 13, 2015
@ghost
ghost deleted the rustup-curl-silent-flag branch March 13, 2015 08:36
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 14, 2026
fix: Fix `hir::Type` owner mismatches between anon consts
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants