Repository navigation
Drop array elements in order after a partial move - #165037
Open
yashaggarwal85d wants to merge 1 commit into
Open
yashaggarwal85d wants to merge 1 commit into
yashaggarwal85d wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? mir |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an array may have been partially moved out by an array pattern, drop elaboration splits it into
kept indices and dropped subslices, but then built the drop ladder over those pieces in reverse. So
let a = [D(1), D(2)]; if false { let [_x, _] = a; }dropped 2 before 1. The reversal came in with#109008; before that the ladder went first to last, which is what the Reference says.
This removes the
.rev()and adds a run-pass test. Two existing drop-order tests(
if-let-guards.rs,or-pattern-drop-order.rs) were asserting the reversed order, so I fixed their expectations.Fixes #164809
AI was used to write tests for this. I reviewed the changes myself. Thanks