Repository navigation
Keep known_panics_lint values across single-predecessor assert edges - #164998
Open
yashaggarwal85d wants to merge 2 commits into
Open
yashaggarwal85d wants to merge 2 commits into
yashaggarwal85d wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Reopening after a conversation with the author |
Member
|
@rustbot reroll |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KnownPanicsLint drops values of locals that are assigned more than once at the end of each block.
With overflow checks on,
x >>= nputs an assert before the shift, so the shift ends up in the nextblock and the lint loses
xright there. This keeps visiting into the assert/goto target when it hasonly one predecessor, and clears those locals once that chain ends.
Same applies to
/=and%=(div-by-zero assert), which were missed even with-O.Fixes #164191