Repository navigation
Use the updated buffer length in UEFI locate_handles - #164955
Merged
rust-bors[bot] merged 1 commit intoOct 26, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
Error: Failed to set assignee to
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
Member
|
Yes, this is unsound, but it's more subtle than the issue points out. UEFI does not have a way to close handles, and does not have any asynchronous callback facilities that could cause a protocol to be closed for the handle, so something like device hotplugging cannot cause an issue here. But we make a call to the global allocator in between the calls to @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…ndles-len, r=joboet Use the updated buffer length in UEFI locate_handles locate_handles was using the handle count from the first LocateHandle call when setting the vec length, instead of the size the second call actually wrote. If handles go away between the two calls this marks uninitialized entries as initialized. Use the updated buf_len instead. Fixes rust-lang#164945
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164955 (Use the updated buffer length in UEFI locate_handles) - #164958 (uefi: roll back env changes when `start_image` fails) - #164968 (thread_local::guard: update comments a bit) - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - #164674 (Use a NoSpan marker for region constraints without spans) - #164856 (Switch from `insta` to `expect-test` in bootstrap) - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - #164954 (Reduce `SpanData` use)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164955 (Use the updated buffer length in UEFI locate_handles) - #164958 (uefi: roll back env changes when `start_image` fails) - #164968 (thread_local::guard: update comments a bit) - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - #164674 (Use a NoSpan marker for region constraints without spans) - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - #164954 (Reduce `SpanData` use) - #164970 (`rust-analyzer` subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup merge of #164955 - yashaggarwal85d:fix-uefi-locate-handles-len, r=joboet Use the updated buffer length in UEFI locate_handles locate_handles was using the handle count from the first LocateHandle call when setting the vec length, instead of the size the second call actually wrote. If handles go away between the two calls this marks uninitialized entries as initialized. Use the updated buf_len instead. Fixes #164945
This comment was marked as low quality.
This comment was marked as low quality.
BenMac31
pushed a commit
to graphide-oss/rust-analyzer
that referenced
this pull request
Nov 2, 2026
…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#164955 (Use the updated buffer length in UEFI locate_handles) - rust-lang/rust#164958 (uefi: roll back env changes when `start_image` fails) - rust-lang/rust#164968 (thread_local::guard: update comments a bit) - rust-lang/rust#164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - rust-lang/rust#164674 (Use a NoSpan marker for region constraints without spans) - rust-lang/rust#164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - rust-lang/rust#164954 (Reduce `SpanData` use) - rust-lang/rust#164970 (`rust-analyzer` subtree update)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locate_handles was using the handle count from the first LocateHandle call when setting the
vec length, instead of the size the second call actually wrote. If handles go away between
the two calls this marks uninitialized entries as initialized. Use the updated buf_len instead.
Fixes #164945