Repository navigation
Conversation
rustbot
added
S-waiting-on-review
Member
|
looks good to me! r=me but could you add some sort of comment here in reference to the fact that this ideally would not be needed and instead we have proper impl generic args whose types are in impl generic arg format? (if you'd like, perhaps adding same comment, just above, in the comment added by #164318 - both this and that should probably be reverted when things are synthed) it's also up to you on whether you'd like to merge this patch-over-the-hack fix, or only just do the proper fix and close this. |
bit-aloo
marked this pull request as draft
October 27, 2026 10:05
rustbot
added
S-waiting-on-author
rust-cloud-vms
Bot
force-pushed
the
2026-10-24-rpitit-const-param-type-ic
branch
from
October 30, 2026 10:03
cd9a80f to
1044405
Compare
bit-aloo
commented
Oct 30, 2026
| query ty_span(def_id: LocalDefId) -> Span { | ||
| desc { "looking up span for `{}`'s type", tcx.def_path_str(def_id) } | ||
| cache_on_disk | ||
| feedable |
Member
Author
There was a problem hiding this comment.
We are making ty_span feedable here, so its not great for incremental compilation making this query forever_red_node
rust-cloud-vms
Bot
force-pushed
the
2026-10-24-rpitit-const-param-type-ic
branch
from
October 30, 2026 10:32
1044405 to
e66d46c
Compare
bit-aloo
commented
Oct 30, 2026
| @@ -0,0 +1,29 @@ | |||
| //! Regression test for #153375. | |||
Member
Author
There was a problem hiding this comment.
This is the test which used to crash earlier.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #164710
surprisingly closes: #153375
This started with #162908, where we started translating the traits const parameter types into the impls context before comparing them.However, in case of RPITIT, the impl item hidden type reuses the traits generic params, so their types are still written using the traits param indices. We were reading them using the impls indices instead, causing a mismatch. This kinda hit an error path that callsname()on the hidden type, which has no name, and cause ICE.r? @khyperia