Skip to content

Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck - #164307

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Jamesbarford:chore/PostTypeckUntilBorrowck-rename
Oct 23, 2026
Merged

Rename PostTypeckUntilBorrowck -> PostTypeckThroughBorrowck#164307
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Jamesbarford:chore/PostTypeckUntilBorrowck-rename

Conversation

@Jamesbarford

@Jamesbarford Jamesbarford commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

This was a rename suggested in the following Zulip thread

r? jdonszelmann

@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 14, 2026
@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@Jamesbarford
Jamesbarford force-pushed the chore/PostTypeckUntilBorrowck-rename branch from a7b6a3d to 03d489d Compare October 14, 2026 10:20
lqd
lqd reviewed Oct 14, 2026
View reviewed changes
Comment thread compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs Outdated
// A non-defining use. This is a hard error on stable and gets ignored
// with `TypingMode::PostTypeckUntilBorrowck`.
// with `TypingMode::PostTypeckThroughBorrowck`.
if infcx.tcx.use_typing_mode_post_typeck_until_borrowck() {

@lqd lqd Oct 14, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably this also needs renaming, as well as the -Z option?

View changes since the review

@lcnr lcnr Oct 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe easier to entirely yeet the -Z option, it only exists to also test stuff iwth the old solver and that has always been kinda broken and now with the next-solver stabilization, does not matter

@Jamesbarford Jamesbarford Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

71ee80a Think this yeets it

@jdonszelmann

jdonszelmann commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Yea, the functions should also be renamed, and also be careful with comments

@Jamesbarford
Jamesbarford force-pushed the chore/PostTypeckUntilBorrowck-rename branch from 03d489d to 71ee80a Compare October 19, 2026 09:41
@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in match checking

cc @Nadrieril

@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jamesbarford

Jamesbarford commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yea, the functions should also be renamed, and also be careful with comments

I think I've now hit all of the locations 2cf8532. I found the locations using;

grep -rinsI ./compiler -e 'until_borrowchk'
grep -rinsI ./compiler -e 'until borrow'
grep -rinsI ./compiler -e 'UntilBorrow'

Then used sed to replace

@jdonszelmann

jdonszelmann commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Looks good, @bors r+

@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 71ee80a has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 22, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 22, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
b8fa1fb 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
eb022b1 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
0cefa27 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
@rust-bors
rust-bors Bot merged commit 56e00d5 into rust-lang:main Oct 23, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 23, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Unrolled build for #164307 in rollup 164757
e69fad2 
Rollup merge of #164307 - Jamesbarford:chore/PostTypeckUntilBorrowck-rename, r=jdonszelmann

Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`

This was a rename suggested in the following [Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/618216-t-types.2Fcall-for-participation/topic/rename.20.60TypingMode.3A.3APostTypeckThroughBorrowck.60/with/624384207)

r? jdonszelmann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd left review comments
@lcnr lcnr lcnr left review comments

Assignees

@jdonszelmann jdonszelmann

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jamesbarford @rustbot @jdonszelmann @lqd @lcnr