Repository navigation
Improve --bless output for tests/debuginfo - #164201
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
Sorting the types by name makes sense. Thanks! r? kobzol @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 12, 2026
Improve `--bless` output for `tests/debuginfo` Fixes a few small things that came up while writing a new test. The first commit fixes a small bug that caused unsigned integer values to be unpacked as signed values. The second forces `\n` line endings, which makes running `--bless` less annoying on windows. Python defaults to platform specific line-endings by default. I think git normalizes away the differences anyway? But when working, they'd show up as changed files, so this just prevents those phantom diffs. The bigger change in the second commit is sorting the types dictionary, which should help prevent diffs that are just shuffling types around. For reference, python (3.7+) dictionaries are in insertion order by default, so adding a new variable could sometimes cause a type to be processed sooner or later than it had been before. All other list/dict instances *are* order-sensitive and/or changing their position has significance in the test, so those have remained the same. r? @jieyouxu, @Kobzol
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 12, 2026
Improve `--bless` output for `tests/debuginfo` Fixes a few small things that came up while writing a new test. The first commit fixes a small bug that caused unsigned integer values to be unpacked as signed values. The second forces `\n` line endings, which makes running `--bless` less annoying on windows. Python defaults to platform specific line-endings by default. I think git normalizes away the differences anyway? But when working, they'd show up as changed files, so this just prevents those phantom diffs. The bigger change in the second commit is sorting the types dictionary, which should help prevent diffs that are just shuffling types around. For reference, python (3.7+) dictionaries are in insertion order by default, so adding a new variable could sometimes cause a type to be processed sooner or later than it had been before. All other list/dict instances *are* order-sensitive and/or changing their position has significance in the test, so those have remained the same. r? @jieyouxu, @Kobzol
This was referenced Oct 12, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 12, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164196 (`rust-analyzer` subtree update) - #164037 (Restrict application of optimization attributes from instance) - #164201 (Improve `--bless` output for `tests/debuginfo`) - #164202 ([rustdoc] Move the creation of `IndividualTestOptions` into the test runner closure to ensure the temporary folder is removed right after the test is done running) - #162140 (fn_addr_eq: we actually can guarantee basically nothing) - #163946 (Fix transmutability type mismatch bug) - #163978 (Copy over some methods from At to InferCtxt) - #164045 (-Zassumptions-on-binders: replace region vars with bound vars when handling alias outlives')
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 12, 2026
Rollup merge of #164201 - Walnut356:unsigned_unpack, r=Kobzol Improve `--bless` output for `tests/debuginfo` Fixes a few small things that came up while writing a new test. The first commit fixes a small bug that caused unsigned integer values to be unpacked as signed values. The second forces `\n` line endings, which makes running `--bless` less annoying on windows. Python defaults to platform specific line-endings by default. I think git normalizes away the differences anyway? But when working, they'd show up as changed files, so this just prevents those phantom diffs. The bigger change in the second commit is sorting the types dictionary, which should help prevent diffs that are just shuffling types around. For reference, python (3.7+) dictionaries are in insertion order by default, so adding a new variable could sometimes cause a type to be processed sooner or later than it had been before. All other list/dict instances *are* order-sensitive and/or changing their position has significance in the test, so those have remained the same. r? @jieyouxu, @Kobzol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few small things that came up while writing a new test.
The first commit fixes a small bug that caused unsigned integer values to be unpacked as signed values.
The second forces
\nline endings, which makes running--blessless annoying on windows. Python defaults to platform specific line-endings by default. I think git normalizes away the differences anyway? But when working, they'd show up as changed files, so this just prevents those phantom diffs.The bigger change in the second commit is sorting the types dictionary, which should help prevent diffs that are just shuffling types around. For reference, python (3.7+) dictionaries are in insertion order by default, so adding a new variable could sometimes cause a type to be processed sooner or later than it had been before.
All other list/dict instances are order-sensitive and/or changing their position has significance in the test, so those have remained the same.
r? @jieyouxu, @Kobzol