[rustdoc] Prefer local paths over remote ones when foreign item is locally reexported by GuillaumeGomez · Pull Request #164007 · rust-lang/rust

GuillaumeGomez · 2026-10-08T20:31:19Z

This is the last failure from #162808:

src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html`

std reexports Error locally, and alloc is the one implementing the Error::new method. So std has both Error and Error::new locally. So instead of trying to link to core::Error::new (which doesn't exist), we first check if we locally reexport Error with the paths map and use it as a shortcut.

PS: I got annoyed about adding/removing #[derive(Debug)] every time so this time I just leave them there. :3

r? @Urgau

…ported

GuillaumeGomez · 2026-10-09T07:23:57Z

@bors r=Urgau rollup

rust-bors · 2026-10-09T07:24:00Z

📌 Commit 3e422d6 has been approved by Urgau

It is now in the queue for this repository.

@Urgau

…d, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from rust-lang#162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

…uwer Rollup of 4 pull requests Successful merges: - #163666 (Updates the expect message library/core/src/time.rs) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)

@Urgau

…d, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from rust-lang#162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

…uwer Rollup of 11 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)

@Urgau

…d, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from rust-lang#162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

@Urgau

…d, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from rust-lang#162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

@Urgau

…d, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from rust-lang#162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

…uwer Rollup of 24 pull requests Successful merges: - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - #162106 (Helpful suggestions for incorrect address-of mutability (2)) - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - #163939 (Better debug impls for some assumptions on binders types) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #164042 (Allow testing cg-gcc on any target) - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - #162908 (Fix - const parameters rejected when identical) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164008 (properly ignore the current goal's usages) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

@Urgau

Rollup merge of #164007 - GuillaumeGomez:local-path-preferred, r=Urgau [rustdoc] Prefer local paths over remote ones when foreign item is locally reexported This is the last failure from #162808: ``` src/std/sys/fs/unix.rs.html:1171: broken link fragment `#method.new` pointing to `core/io/struct.Error.html` ``` `std` reexports `Error` locally, and `alloc` is the one implementing the `Error::new` method. So `std` has both `Error` and `Error::new` locally. So instead of trying to link to `core::Error::new` (which doesn't exist), we first check if we locally reexport `Error` with the `paths` map and use it as a shortcut. PS: I got annoyed about adding/removing `#[derive(Debug)]` every time so this time I just leave them there. :3 r? @Urgau

…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - rust-lang/rust#162106 (Helpful suggestions for incorrect address-of mutability (2)) - rust-lang/rust#162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - rust-lang/rust#163337 (MIR move elimination [3/6]: PreciseLiveness) - rust-lang/rust#163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - rust-lang/rust#163939 (Better debug impls for some assumptions on binders types) - rust-lang/rust#163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - rust-lang/rust#163956 (Pass the unremapped path to the `rustc` invocation for doctests) - rust-lang/rust#164042 (Allow testing cg-gcc on any target) - rust-lang/rust#162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - rust-lang/rust#162908 (Fix - const parameters rejected when identical) - rust-lang/rust#163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - rust-lang/rust#163634 (move overflow lint computation into decorator) - rust-lang/rust#163666 (Updates the expect message library/core/src/time.rs) - rust-lang/rust#163727 (rigid aliases to non-rigid for fully normalized check) - rust-lang/rust#163745 (replace `fully_monomorphized` with `cx.typing_env()`) - rust-lang/rust#163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - rust-lang/rust#163950 (don't treat inherited opaques as defining) - rust-lang/rust#163972 (const-eval: ICE when we hit a non-const fn) - rust-lang/rust#164000 (When mentioning that closure doesn't implement trait, point at closure) - rust-lang/rust#164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - rust-lang/rust#164008 (properly ignore the current goal's usages) - rust-lang/rust#164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - rust-lang/rust#164025 (Less `CanonicalVarValues`)

rustbot assigned Urgau Oct 8, 2026

Prefer local paths over remote ones when foreign item is locally reex…

3e422d6

…ported

GuillaumeGomez force-pushed the local-path-preferred branch from c8aedc2 to 3e422d6 Compare October 8, 2026 20:40

Urgau approved these changes Oct 8, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2026

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 4 pull requests #164022

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 11 pull requests #164024

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164026

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164027

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164039

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 24 pull requests #164052

Merged

rust-bors Bot merged commit c7293f9 into rust-lang:main Oct 9, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 9, 2026

GuillaumeGomez deleted the local-path-preferred branch October 10, 2026 14:55

Navigation Menu

Repository navigation

[rustdoc] Prefer local paths over remote ones when foreign item is locally reexported - #164007

[rustdoc] Prefer local paths over remote ones when foreign item is locally reexported#164007
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:local-path-preferred

GuillaumeGomez commented Oct 8, 2026

Uh oh!

GuillaumeGomez commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

GuillaumeGomez commented Oct 8, 2026

Uh oh!

GuillaumeGomez commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants