mips: make `Complex<T>` ABI match GCC by folkertdev · Pull Request #163617 · rust-lang/rust

+    let dl = cx.data_layout();
+    let size = ret.layout.size;
+
+    // Complex types with unsupported component types are passed as an aggregate.


Suggested change

// Complex types with unsupported component types are passed as an aggregate.

// Complex types with unsupported component types are returned as an aggregate.

rust-bors · 2026-10-07T22:46:16Z

This pull request was unapproved.

View changes since this unapproval

rustbot · 2026-10-08T08:58:56Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev · 2026-10-08T09:00:15Z

@bors r=beetrees rollup

rust-bors · 2026-10-08T09:00:18Z

📌 Commit 02f6b38 has been tentatively approved by beetrees

It will be put into the queue for this repository once PR CI succeeds.

mips: make `Complex<T>` ABI match GCC tracking issue: rust-lang#154023 The implementation is consistent with GCC and clang 24 (but not clang <= 23). Validated with abi-cafe. r? beetrees

…uwer Rollup of 9 pull requests Successful merges: - #163462 (Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports) - #163855 (Include enclosing item's context on const errors) - #163861 (Run LLDB debuginfo tests on `x86_64-mingw`) - #163538 (Add `rustc::missing_generic_type_visitable` lint) - #163617 (mips: make `Complex<T>` ABI match GCC) - #163832 (reject non-async coroutine closures as async callables) - #163958 (only make `RustaceansAreAwesome` satisfy trait clauses) - #163974 (Condense AdtDef lang item checks into one match) - #163979 (Add `bf16` to arm features) Failed merges: - #163972 (const-eval: ICE when we hit a non-const fn)

mips: make `Complex<T>` ABI match GCC tracking issue: rust-lang#154023 The implementation is consistent with GCC and clang 24 (but not clang <= 23). Validated with abi-cafe. r? beetrees

…uwer Rollup of 12 pull requests Successful merges: - #163462 (Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports) - #163855 (Include enclosing item's context on const errors) - #163861 (Run LLDB debuginfo tests on `x86_64-mingw`) - #161201 (Speed up tidy again) - #163538 (Add `rustc::missing_generic_type_visitable` lint) - #163617 (mips: make `Complex<T>` ABI match GCC) - #163772 (comptime fn error: suggest wrapping in const block) - #163832 (reject non-async coroutine closures as async callables) - #163958 (only make `RustaceansAreAwesome` satisfy trait clauses) - #163974 (Condense AdtDef lang item checks into one match) - #163979 (Add `bf16` to arm features) - #163989 (Revert "compiletest: stream output of executor process when --no-capture is set") Failed merges: - #163972 (const-eval: ICE when we hit a non-const fn)

…uwer Rollup of 19 pull requests Successful merges: - #156112 (Distinguish `repr(C)` ZSTs from others in ABI computation) - #157941 (Deny partial `-Z stack-protector` by default in all editions) - #163462 (Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports) - #163855 (Include enclosing item's context on const errors) - #163861 (Run LLDB debuginfo tests on `x86_64-mingw`) - #163913 ( Silence redundant failed obligations on the same statement) - #161201 (Speed up tidy again) - #163380 (Tweak "name not found" resolution error when it happens from within a derive expansion) - #163538 (Add `rustc::missing_generic_type_visitable` lint) - #163617 (mips: make `Complex<T>` ABI match GCC) - #163772 (comptime fn error: suggest wrapping in const block) - #163813 (use pre-borrowck typing env for early MIR validation) - #163924 (replace instances of NonNull::new(&mut x).expect("...") with NonNull::from_mut) - #163958 (only make `RustaceansAreAwesome` satisfy trait clauses) - #163960 (vexos: clear .bss from assembly) - #163974 (Condense AdtDef lang item checks into one match) - #163979 (Add `bf16` to arm features) - #163989 (Revert "compiletest: stream output of executor process when --no-capture is set") - #163995 (m68k-unknown-none-elf: Remove code model) Failed merges: - #163832 (reject non-async coroutine closures as async callables) - #163972 (const-eval: ICE when we hit a non-const fn)

Rollup merge of #163617 - folkertdev:complex-mips, r=beetrees mips: make `Complex<T>` ABI match GCC tracking issue: #154023 The implementation is consistent with GCC and clang 24 (but not clang <= 23). Validated with abi-cafe. r? beetrees

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#156112 (Distinguish `repr(C)` ZSTs from others in ABI computation) - rust-lang/rust#157941 (Deny partial `-Z stack-protector` by default in all editions) - rust-lang/rust#163462 (Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports) - rust-lang/rust#163855 (Include enclosing item's context on const errors) - rust-lang/rust#163861 (Run LLDB debuginfo tests on `x86_64-mingw`) - rust-lang/rust#163913 ( Silence redundant failed obligations on the same statement) - rust-lang/rust#161201 (Speed up tidy again) - rust-lang/rust#163380 (Tweak "name not found" resolution error when it happens from within a derive expansion) - rust-lang/rust#163538 (Add `rustc::missing_generic_type_visitable` lint) - rust-lang/rust#163617 (mips: make `Complex<T>` ABI match GCC) - rust-lang/rust#163772 (comptime fn error: suggest wrapping in const block) - rust-lang/rust#163813 (use pre-borrowck typing env for early MIR validation) - rust-lang/rust#163924 (replace instances of NonNull::new(&mut x).expect("...") with NonNull::from_mut) - rust-lang/rust#163958 (only make `RustaceansAreAwesome` satisfy trait clauses) - rust-lang/rust#163960 (vexos: clear .bss from assembly) - rust-lang/rust#163974 (Condense AdtDef lang item checks into one match) - rust-lang/rust#163979 (Add `bf16` to arm features) - rust-lang/rust#163989 (Revert "compiletest: stream output of executor process when --no-capture is set") - rust-lang/rust#163995 (m68k-unknown-none-elf: Remove code model) Failed merges: - rust-lang/rust#163832 (reject non-async coroutine closures as async callables) - rust-lang/rust#163972 (const-eval: ICE when we hit a non-const fn)

folkertdev added the F-complex_numbers `#![feature(complex_numbers)]` label Oct 1, 2026

rustbot assigned beetrees Oct 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 1, 2026

beetrees reviewed Oct 7, 2026

View reviewed changes

Comment thread compiler/rustc_target/src/callconv/mips.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026

folkertdev force-pushed the complex-mips branch from 00f250c to 7744d4b Compare October 7, 2026 22:28

This comment has been minimized.

Sign in to view

folkertdev force-pushed the complex-mips branch 2 times, most recently from 25679e1 to e9915bb Compare October 7, 2026 22:35

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2026

beetrees approved these changes Oct 7, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026

beetrees requested changes Oct 7, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2026

_Complex for mips

02f6b38

folkertdev force-pushed the complex-mips branch from e9915bb to 02f6b38 Compare October 8, 2026 08:58

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2026

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 8 pull requests #163984

Closed

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 9 pull requests #163987

Closed

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 12 pull requests #163993

Closed

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 19 pull requests #164005

Merged

rust-bors Bot merged commit 30a1a4a into rust-lang:main Oct 8, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 8, 2026

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Navigation Menu

Repository navigation

mips: make `Complex<T>` ABI match GCC - #163617

mips: make `Complex<T>` ABI match GCC#163617
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:complex-mips

folkertdev commented Oct 1, 2026

Uh oh!

rustbot commented Oct 1, 2026

Uh oh!

beetrees left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

rustbot commented Oct 7, 2026

Uh oh!

This comment has been minimized.

beetrees left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Oct 7, 2026

Uh oh!

beetrees left a comment •

edited by rustbot

Loading

Uh oh!

beetrees Oct 7, 2026

Uh oh!

rust-bors Bot commented Oct 7, 2026

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

folkertdev commented Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// Complex types with unsupported component types are passed as an aggregate.
	// Complex types with unsupported component types are returned as an aggregate.

Conversation

folkertdev commented Oct 1, 2026

Uh oh!

rustbot commented Oct 1, 2026

Uh oh!

beetrees left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Oct 7, 2026

Uh oh!

This comment has been minimized.

beetrees left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 7, 2026

Uh oh!

beetrees left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beetrees Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 7, 2026

Uh oh!

rustbot commented Oct 8, 2026

Uh oh!

folkertdev commented Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

beetrees left a comment •

edited by rustbot

Loading

beetrees left a comment •

edited by rustbot

Loading

beetrees left a comment •

edited by rustbot

Loading