Skip to content

Add tests for ! and bool's size and alignment to coretests. - #163570

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zachs18:never-bool-size-align-test
Oct 2, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zachs18:never-bool-size-align-test

Conversation

@zachs18

@zachs18 zachs18 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Add tests for bool and !'s size and alignment to coretests/tests/mem.rs

cc @tgross35

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2026
@rustbot

rustbot commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from Darksonn, JohnTitor, Mark-Simulacrum, clarfonthey

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here could you also add ()?

View changes since this review

@zachs18
zachs18 force-pushed the never-bool-size-align-test branch from 66cc74c to 1416718 Compare October 1, 2026 22:43
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1416718 has been tentatively approved by tgross35

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 2, 2026
Rollup of 8 pull requests

Successful merges:

 - #162556 (Refactor CodeGen Pipeline Setup into a Single Function)
 - #163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases)
 - #163621 (core: Unstably constify `abort_immediate`)
 - #161904 (declare C and C-unwind as mutually ABI-compatible)
 - #163144 (Add Tier 3 targets for Hyperlight guests)
 - #163537 (remove unnecessary panic from opsem inhabitedness calculation)
 - #163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.)
 - #163606 (ignore hanging next-solver tests, remove unnecessary ignore test)

Failed merges:

 - #163572 (Update the minimum external LLVM to 22)
@rust-bors
rust-bors Bot merged commit 37062d7 into rust-lang:main Oct 2, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 2, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 2, 2026
Rollup merge of #163570 - zachs18:never-bool-size-align-test, r=tgross35

Add tests for `!` and `bool`'s size and alignment to `coretests`.

Add tests for `bool` and `!`'s size and alignment to `coretests/tests/mem.rs`

cc @tgross35
LorrensP-2158466 pushed a commit to LorrensP-2158466/miri that referenced this pull request Oct 6, 2026
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#162556 (Refactor CodeGen Pipeline Setup into a Single Function)
 - rust-lang/rust#163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases)
 - rust-lang/rust#163621 (core: Unstably constify `abort_immediate`)
 - rust-lang/rust#161904 (declare C and C-unwind as mutually ABI-compatible)
 - rust-lang/rust#163144 (Add Tier 3 targets for Hyperlight guests)
 - rust-lang/rust#163537 (remove unnecessary panic from opsem inhabitedness calculation)
 - rust-lang/rust#163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.)
 - rust-lang/rust#163606 (ignore hanging next-solver tests, remove unnecessary ignore test)

Failed merges:

 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants