[estebank]

error: invalid definition of the runtime `open` symbol used by the standard library
  --> $DIR/runtime-symbols-unix.rs:14:5
   |
LL |     pub fn open() {}
   |     ^^^^^^^^^^^^^
   |
   = note: expected `unsafe extern "C" fn(*const U8, i32, ...) -> i32` (for the current target)
              found `fn()`
   = help: either fix the signature or remove any attributes like `#[unsafe(no_mangle)]`, `#[unsafe(export_name = "open")]`, or `#[link_name = "open"]`
   = note: `#[deny(invalid_runtime_symbol_definitions)]` on by default

r? @JonathanBrouwer

[rustbot]

rustc_macros::diagnostics was changed

cc @TaKO8Ki, @JonathanBrouwer

[rustbot]

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

[JonathanBrouwer]

@bors r+ rollup

View changes since this review

[rust-bors]

📌 Commit 9dfa371 has been approved by JonathanBrouwer

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 4m 34s
Pushing 51c768a to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 28b6e69 (parent) -> 51c768a (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 51c768aa5cb99ae7670e97b0e8392f926e79855e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. test-i686-gnu-nopt-2: 1h 22m -> 2h 26m (+76.4%)
2. test-x86_64-gnu-debug: 1h 22m -> 2h 14m (+62.4%)
3. dist-loongarch64-linux: 1h 19m -> 2h 7m (+60.6%)
4. test-x86_64-gnu-llvm-21-3: 1h 21m -> 1h 59m (+46.1%)
5. test-i686-gnu-2: 1h 15m -> 1h 48m (+44.4%)
6. dist-powerpc-linux: 1h 8m -> 1h 31m (+34.9%)
7. test-x86_64-gnu-aux: 2h 45m -> 1h 50m (-33.4%)
8. test-x86_64-msvc-1: 2h 7m -> 2h 49m (+33.1%)
9. test-x86_64-msvc-ext2: 1h 10m -> 1h 32m (+31.5%)
10. test-x86_64-gnu-miri: 1h 29m -> 1h 1m (-30.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (51c768a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.5%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	1.6%	[0.4%, 2.9%]	3
Improvements ✅ (primary)	-1.8%	[-2.0%, -1.5%]	2
Improvements ✅ (secondary)	-2.8%	[-3.5%, -2.2%]	4
All ❌✅ (primary)	-0.5%	[-2.0%, 2.1%]	3

Cycles

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.07s -> 488.57s (0.10%)
Artifact size: 406.39 MiB -> 406.43 MiB (0.01%)