Skip to content

Cleanup offload build steps - #163179

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ZuseZ4:cleanup-offload
Sep 23, 2026
Merged

rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ZuseZ4:cleanup-offload

Conversation

@ZuseZ4

@ZuseZ4 ZuseZ4 commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass.

r? oli-obk

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2026
@ZuseZ4
ZuseZ4 marked this pull request as ready for review September 22, 2026 22:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2026
@bjorn3

bjorn3 commented Sep 23, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4f20be3 has been approved by bjorn3

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 23, 2026
Cleanup offload build steps

We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass.

r? oli-obk
rust-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
 - #163168 (std: Update `wasip3` crate dependency)
 - #163179 (Cleanup offload build steps)
 - #163194 (Remove unused `StashKey::UnderscoreForArrayLengths`)
 - #163198 (rename direct_const_arg! to gca!)
 - #163205 (Remove `suggestion_for_allocator_api`)
 - #162497 (document `#[rustc_dyn_incompatible_trait]`)
 - #162702 (regression test for unconstrained const args)
 - #163191 (Enhance mutable closure suggestions with as_mut() support)
 - #163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs)
 - #163196 (Remove `DiagInner::sort_span`)
 - #163197 (Fix flt2dec build on 16-bit targets)
@rust-bors
rust-bors Bot merged commit e43f8c5 into rust-lang:main Sep 23, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 23, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
Rollup merge of #163179 - ZuseZ4:cleanup-offload, r=bjorn3

Cleanup offload build steps

We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass.

r? oli-obk
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Sep 28, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#162177 (Properly implement the gpu-kernel ABI for amdgpu)
 - rust-lang/rust#163168 (std: Update `wasip3` crate dependency)
 - rust-lang/rust#163179 (Cleanup offload build steps)
 - rust-lang/rust#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`)
 - rust-lang/rust#163198 (rename direct_const_arg! to gca!)
 - rust-lang/rust#163205 (Remove `suggestion_for_allocator_api`)
 - rust-lang/rust#162497 (document `#[rustc_dyn_incompatible_trait]`)
 - rust-lang/rust#162702 (regression test for unconstrained const args)
 - rust-lang/rust#163191 (Enhance mutable closure suggestions with as_mut() support)
 - rust-lang/rust#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs)
 - rust-lang/rust#163196 (Remove `DiagInner::sort_span`)
 - rust-lang/rust#163197 (Fix flt2dec build on 16-bit targets)
makai410 pushed a commit to makai410/rust that referenced this pull request Oct 1, 2026
…nathanBrouwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang#162177 (Properly implement the gpu-kernel ABI for amdgpu)
 - rust-lang#163168 (std: Update `wasip3` crate dependency)
 - rust-lang#163179 (Cleanup offload build steps)
 - rust-lang#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`)
 - rust-lang#163198 (rename direct_const_arg! to gca!)
 - rust-lang#163205 (Remove `suggestion_for_allocator_api`)
 - rust-lang#162497 (document `#[rustc_dyn_incompatible_trait]`)
 - rust-lang#162702 (regression test for unconstrained const args)
 - rust-lang#163191 (Enhance mutable closure suggestions with as_mut() support)
 - rust-lang#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs)
 - rust-lang#163196 (Remove `DiagInner::sort_span`)
 - rust-lang#163197 (Fix flt2dec build on 16-bit targets)
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Oct 1, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#162177 (Properly implement the gpu-kernel ABI for amdgpu)
 - rust-lang/rust#163168 (std: Update `wasip3` crate dependency)
 - rust-lang/rust#163179 (Cleanup offload build steps)
 - rust-lang/rust#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`)
 - rust-lang/rust#163198 (rename direct_const_arg! to gca!)
 - rust-lang/rust#163205 (Remove `suggestion_for_allocator_api`)
 - rust-lang/rust#162497 (document `#[rustc_dyn_incompatible_trait]`)
 - rust-lang/rust#162702 (regression test for unconstrained const args)
 - rust-lang/rust#163191 (Enhance mutable closure suggestions with as_mut() support)
 - rust-lang/rust#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs)
 - rust-lang/rust#163196 (Remove `DiagInner::sort_span`)
 - rust-lang/rust#163197 (Fix flt2dec build on 16-bit targets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants