Cleanup offload build steps - #163179
Merged
Merged
Cleanup offload build steps#163179
Conversation
ZuseZ4
marked this pull request as ready for review
September 22, 2026 22:19
Member
|
@bors r+ |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 23, 2026
Cleanup offload build steps We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass. r? oli-obk
This was referenced Sep 23, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
…uwer Rollup of 12 pull requests Successful merges: - #162177 (Properly implement the gpu-kernel ABI for amdgpu) - #163168 (std: Update `wasip3` crate dependency) - #163179 (Cleanup offload build steps) - #163194 (Remove unused `StashKey::UnderscoreForArrayLengths`) - #163198 (rename direct_const_arg! to gca!) - #163205 (Remove `suggestion_for_allocator_api`) - #162497 (document `#[rustc_dyn_incompatible_trait]`) - #162702 (regression test for unconstrained const args) - #163191 (Enhance mutable closure suggestions with as_mut() support) - #163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs) - #163196 (Remove `DiagInner::sort_span`) - #163197 (Fix flt2dec build on 16-bit targets)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Rollup merge of #163179 - ZuseZ4:cleanup-offload, r=bjorn3 Cleanup offload build steps We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass. r? oli-obk
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Sep 28, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#162177 (Properly implement the gpu-kernel ABI for amdgpu) - rust-lang/rust#163168 (std: Update `wasip3` crate dependency) - rust-lang/rust#163179 (Cleanup offload build steps) - rust-lang/rust#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`) - rust-lang/rust#163198 (rename direct_const_arg! to gca!) - rust-lang/rust#163205 (Remove `suggestion_for_allocator_api`) - rust-lang/rust#162497 (document `#[rustc_dyn_incompatible_trait]`) - rust-lang/rust#162702 (regression test for unconstrained const args) - rust-lang/rust#163191 (Enhance mutable closure suggestions with as_mut() support) - rust-lang/rust#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs) - rust-lang/rust#163196 (Remove `DiagInner::sort_span`) - rust-lang/rust#163197 (Fix flt2dec build on 16-bit targets)
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Oct 1, 2026
…nathanBrouwer Rollup of 12 pull requests Successful merges: - rust-lang#162177 (Properly implement the gpu-kernel ABI for amdgpu) - rust-lang#163168 (std: Update `wasip3` crate dependency) - rust-lang#163179 (Cleanup offload build steps) - rust-lang#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`) - rust-lang#163198 (rename direct_const_arg! to gca!) - rust-lang#163205 (Remove `suggestion_for_allocator_api`) - rust-lang#162497 (document `#[rustc_dyn_incompatible_trait]`) - rust-lang#162702 (regression test for unconstrained const args) - rust-lang#163191 (Enhance mutable closure suggestions with as_mut() support) - rust-lang#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs) - rust-lang#163196 (Remove `DiagInner::sort_span`) - rust-lang#163197 (Fix flt2dec build on 16-bit targets)
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Oct 1, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#162177 (Properly implement the gpu-kernel ABI for amdgpu) - rust-lang/rust#163168 (std: Update `wasip3` crate dependency) - rust-lang/rust#163179 (Cleanup offload build steps) - rust-lang/rust#163194 (Remove unused `StashKey::UnderscoreForArrayLengths`) - rust-lang/rust#163198 (rename direct_const_arg! to gca!) - rust-lang/rust#163205 (Remove `suggestion_for_allocator_api`) - rust-lang/rust#162497 (document `#[rustc_dyn_incompatible_trait]`) - rust-lang/rust#162702 (regression test for unconstrained const args) - rust-lang/rust#163191 (Enhance mutable closure suggestions with as_mut() support) - rust-lang/rust#163192 (Fix Typo in `std::sys::process::unix::unsupported::wait_status` Docs) - rust-lang/rust#163196 (Remove `DiagInner::sort_span`) - rust-lang/rust#163197 (Fix flt2dec build on 16-bit targets)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to generate a couple of artifacts only because clang offload tooling required them. Now that we fully control the build steps on the Rust side without clang tooling, we can remove most of them. I'll make a follow-up PR afterwards to also remove device.bin artifacts and pass the normal rustc outputs of the device compilation pass.
r? oli-obk