Make it clear what the alignment needs to be for deallocate - #163171
Merged
rust-bors[bot] merged 1 commit intoSep 23, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
maxdexh
force-pushed
the
allocator-alignment-fit-docs
branch
from
September 22, 2026 19:01
736a9dd to
ae87ada
Compare
kpreid
reviewed
Sep 22, 2026
DanielEScherzer
approved these changes
Sep 22, 2026
maxdexh
force-pushed
the
allocator-alignment-fit-docs
branch
from
September 22, 2026 19:12
ae87ada to
90d7327
Compare
Member
Author
|
Thank you for noticing this! ^^ |
Contributor
|
@rustbot label +A-allocators A-docs |
rustbot
added
A-allocators
Member
|
this is what we intended to say, yeah @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Rollup of 7 pull requests Successful merges: - #163170 (Update deprecated rustc_hir imports) - #156882 (alloc: stabilise `Allocator`) - #163121 (Borrow the destination place with a raw pointer in MIR inlining) - #162824 (link the offload with in-tree lld if possible) - #163018 (implement (OnceLock,LazyLock)::(get_unchecked,get_unchecked_mut)) - #163171 (Make it clear what the alignment needs to be for `deallocate`) - #163176 (Test unused lifetime params for 'type' and 'union')
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Rollup merge of #163171 - maxdexh:allocator-alignment-fit-docs, r=nia-e Make it clear what the alignment needs to be for `deallocate` As noticed on [zulip](https://rust-lang.zulipchat.com/#narrow/channel/197181-t-libs.2Fwg-allocators/topic/Question.3A.20layout.20alignment.20for.20Allocator.3A.3Adeallocate.28.29/with/626111397), this is insufficiently precise r? clarfonthey
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 24, 2026
Rollup of 7 pull requests Successful merges: - rust-lang/rust#163170 (Update deprecated rustc_hir imports) - rust-lang/rust#156882 (alloc: stabilise `Allocator`) - rust-lang/rust#163121 (Borrow the destination place with a raw pointer in MIR inlining) - rust-lang/rust#162824 (link the offload with in-tree lld if possible) - rust-lang/rust#163018 (implement (OnceLock,LazyLock)::(get_unchecked,get_unchecked_mut)) - rust-lang/rust#163171 (Make it clear what the alignment needs to be for `deallocate`) - rust-lang/rust#163176 (Test unused lifetime params for 'type' and 'union')
github-actions Bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Oct 2, 2026
…cs, r=nia-e Make it clear what the alignment needs to be for `deallocate` As noticed on [zulip](https://rust-lang.zulipchat.com/#narrow/channel/197181-t-libs.2Fwg-allocators/topic/Question.3A.20layout.20alignment.20for.20Allocator.3A.3Adeallocate.28.29/with/626111397), this is insufficiently precise r? clarfonthey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed on zulip, this is insufficiently precise
r? clarfonthey