Skip to content

remove unnecessary restriction with next-solver - #163102

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:opaque-type-modulo-regions
Sep 22, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:opaque-type-modulo-regions

Conversation

@lcnr

@lcnr lcnr commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

We previously FCP'd to forbid uses of opaque types which only differ in their lifetime arguments during MIR borrowck in #116935 (comment). This actually did not end up being necessary after all. Will explain this a bit more in the stabilization documentation for the new solver

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2026
@rust-log-analyzer

This comment has been minimized.

@lcnr
lcnr force-pushed the opaque-type-modulo-regions branch from 02e8efe to 919170b Compare September 21, 2026 11:20

@oli-obk oli-obk left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

It was always a bit artificial and impl motivated

View changes since this review

@oli-obk

oli-obk commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 919170b has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 22, 2026
…=oli-obk

remove unnecessary restriction with next-solver

We previously FCP'd to forbid uses of opaque types which only differ in their lifetime arguments during MIR borrowck in rust-lang#116935 (comment). This actually did not end up being necessary after all. Will explain this a bit more in the stabilization documentation for the new solver

r? types
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 22, 2026
…=oli-obk

remove unnecessary restriction with next-solver

We previously FCP'd to forbid uses of opaque types which only differ in their lifetime arguments during MIR borrowck in rust-lang#116935 (comment). This actually did not end up being necessary after all. Will explain this a bit more in the stabilization documentation for the new solver

r? types
rust-bors Bot pushed a commit that referenced this pull request Sep 22, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #147876 (Check tainted_by_error in LateLint)
 - #162998 (Avoid generating overlapping assignments in DSE)
 - #163136 (library: prune allowed lints)
 - #163102 (remove unnecessary restriction with next-solver)
 - #163106 (emit the constant pattern note for raw identifier bindings)
 - #163118 (add `feature(field_projections)` fixme)
 - #163148 (Clean up diagnostic hashing)
@rust-bors
rust-bors Bot merged commit 3a7b5aa into rust-lang:main Sep 22, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 22, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 22, 2026
Rollup merge of #163102 - lcnr:opaque-type-modulo-regions, r=oli-obk

remove unnecessary restriction with next-solver

We previously FCP'd to forbid uses of opaque types which only differ in their lifetime arguments during MIR borrowck in #116935 (comment). This actually did not end up being necessary after all. Will explain this a bit more in the stabilization documentation for the new solver

r? types
@lcnr
lcnr deleted the opaque-type-modulo-regions branch September 24, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants