Report runtime range endpoints for runtime values by chenyukang · Pull Request #163044 · rust-lang/rust

chenyukang · 2026-09-20T02:05:11Z

rustbot · 2026-09-20T02:05:16Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 19 candidates

petrochenkov · 2026-09-20T16:07:20Z

+//! Regression test for https://github.com/rust-lang/rust/issues/131327.
+//! A runtime range endpoint is invalid regardless of its type.
+
+//@ revisions: generic chars both inferred wrong_type late_inferred


Any specific reason to introduce revisions instead of reporting everything in one test?

View changes since the review

I think the advantage is we can focus on special scenario in reviewing the stderr, and also seems easier to find related code in .rs than finding it with lines.

petrochenkov · 2026-09-20T16:12:40Z

r=me after answering #163044 (comment).
@rustbot author

chenyukang · 2026-09-20T23:30:37Z

@bors r=petrochenkov

rust-bors · 2026-09-20T23:30:40Z

📌 Commit 64695f1 has been approved by petrochenkov

It is now in the queue for this repository.

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

Rollup of 15 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #158102 (When compiling without a specified `--edition`, emit a note) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

…uwer Rollup of 18 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #161629 (Streamline `StateDiffCollector`) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #162952 (Depend on lockfiles to prevent GC of the current session) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #158102 (When compiling without a specified `--edition`, emit a note) - #162939 (Declare multi-kind constants for MacroKinds) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

…uwer Rollup of 19 pull requests Successful merges: - #161051 (When error from local macro, include macro def span) - #161629 (Streamline `StateDiffCollector`) - #162750 (add case mapping fast paths for Latin-1) - #162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - #162835 (rustdoc: account for nested parens and split text events in bare urls lint) - #162952 (Depend on lockfiles to prevent GC of the current session) - #163044 (Report runtime range endpoints for runtime values) - #163062 (Use x30 register name with LLVM 23+) - #163091 (miri subtree update) - #162939 (Declare multi-kind constants for MacroKinds) - #162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - #163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - #163019 (Prepare for the introduction of forced keywords (`k#`)) - #163020 (Dir: fix fallback impl for remove_dir) - #163041 (Be more explicit on suggestion type without changing how they are rendered) - #163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - #163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - #163079 (enable `f128` from `u64`/`i64` test) - #163082 (Remove `TypeChecker::root_cx`)

Rollup merge of #163044 - chenyukang:yukang-fix-131327-runtime-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes #131327

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#161051 (When error from local macro, include macro def span) - rust-lang/rust#161629 (Streamline `StateDiffCollector`) - rust-lang/rust#162750 (add case mapping fast paths for Latin-1) - rust-lang/rust#162831 (Do not continue past `rustc_resolve` when encountering duplicated items) - rust-lang/rust#162835 (rustdoc: account for nested parens and split text events in bare urls lint) - rust-lang/rust#162952 (Depend on lockfiles to prevent GC of the current session) - rust-lang/rust#163044 (Report runtime range endpoints for runtime values) - rust-lang/rust#163062 (Use x30 register name with LLVM 23+) - rust-lang/rust#163091 (miri subtree update) - rust-lang/rust#162939 (Declare multi-kind constants for MacroKinds) - rust-lang/rust#162984 (Windows: don't error if `access_mode` is set on `OpenOptions`) - rust-lang/rust#163005 (Avoid unreachable integer underflow check in `CStr::count_bytes()`) - rust-lang/rust#163019 (Prepare for the introduction of forced keywords (`k#`)) - rust-lang/rust#163020 (Dir: fix fallback impl for remove_dir) - rust-lang/rust#163041 (Be more explicit on suggestion type without changing how they are rendered) - rust-lang/rust#163047 (Use verbose suggestion for `mut binding` instead of `&mut binding`) - rust-lang/rust#163075 (Fix ArgAttributes mismatches in ABI UI tests for LoongArch64 and RiscV64) - rust-lang/rust#163079 (enable `f128` from `u64`/`i64` test) - rust-lang/rust#163082 (Remove `TypeChecker::root_cx`)

chenyukang added 2 commits September 20, 2026 09:54

Add regression tests for runtime range pattern endpoints

ea2fa3e

Diagnose runtime range endpoints before reporting unsupported types

64695f1

rustbot assigned petrochenkov Sep 20, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2026

petrochenkov reviewed Sep 20, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 21, 2026

Rollup merge of rust-lang#163044 - chenyukang:yukang-fix-131327-runti…

23d573c

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

Zalathar mentioned this pull request Sep 21, 2026

Rollup of 15 pull requests #163086

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 21, 2026

Rollup merge of rust-lang#163044 - chenyukang:yukang-fix-131327-runti…

c20afc2

…me-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes rust-lang#131327

JonathanBrouwer mentioned this pull request Sep 21, 2026

Rollup of 18 pull requests #163089

Closed

JonathanBrouwer mentioned this pull request Sep 21, 2026

Rollup of 19 pull requests #163095

Merged

rust-bors Bot merged commit 67baf83 into rust-lang:main Sep 21, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 21, 2026

rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026

Unrolled build for #163044 in rollup 163095

adaffca

Rollup merge of #163044 - chenyukang:yukang-fix-131327-runtime-range-patterns, r=petrochenkov Report runtime range endpoints for runtime values Fixes #131327

github-actions Bot mentioned this pull request Oct 2, 2026

Toolchain upgrade to nightly-2026-09-25 flux-rs/flux#1803

Merged

Navigation Menu

Uh oh!

Report runtime range endpoints for runtime values - #163044

Report runtime range endpoints for runtime values#163044
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-131327-runtime-range-patterns

chenyukang commented Sep 20, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Sep 20, 2026

Uh oh!

petrochenkov Sep 20, 2026 •

edited by rustbot

Loading

Uh oh!

chenyukang Sep 20, 2026

Uh oh!

petrochenkov commented Sep 20, 2026

Uh oh!

chenyukang commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chenyukang commented Sep 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 20, 2026

Uh oh!

petrochenkov Sep 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenyukang Sep 20, 2026

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Sep 20, 2026

Uh oh!

chenyukang commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chenyukang commented Sep 20, 2026 •

edited by rustbot

Loading

petrochenkov Sep 20, 2026 •

edited by rustbot

Loading