stop unleaking &muts in std and the compiler - #162766
Merged
Merged
Conversation
rustbot
added
S-waiting-on-author
maxdexh
marked this pull request as ready for review
September 14, 2026 13:18
rustbot
added
S-waiting-on-review
maxdexh
force-pushed
the
unleak-considered-harmful
branch
from
September 14, 2026 13:45
2aaa7e8 to
fe15c63
Compare
Collaborator
|
cc @rust-lang/miri |
Member
|
I can't approve libs changes but count this as an approval for the compiler change |
Contributor
|
r? me @bors r=hanna-kruppe,saethlin rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 14, 2026
Rollup merge of #162766 - maxdexh:unleak-considered-harmful, r=hanna-kruppe,saethlin stop unleaking `&mut`s in std and the compiler As discussed on [zulip](https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/What.20is.20the.20current.20state.20of.20unleaking.20a.20.60Box.3CT.2C.20Global.3E.60.3F/with/623860839), this PR removes all the dubious uses (I could find) of `Box::leak` from rustc and std r? libs
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Sep 15, 2026
…uwer Rollup of 3 pull requests Successful merges: - rust-lang/rust#162409 (Fix gap in const stability checks around intrinsics) - rust-lang/rust#162763 (Remove `Box::into_unique`) - rust-lang/rust#162766 (stop unleaking `&mut`s in std and the compiler)
Collaborator
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (913889f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeResults (secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: missing data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on zulip, this PR removes all the dubious uses (I could find) of
Box::leakfrom rustc and stdr? libs