[beta] make semicolon_in_expressions_from_non_local_macros not report-in-deps by RalfJung · Pull Request #162765 · rust-lang/rust

RalfJung · 2026-09-14T12:56:11Z

See discussion on Zulip:

The lint is showing up a lot more than people seem to have expected.
"Warn" + "report-in-deps" is not a combination we usually use.
This is going to be released soon, let's buy ourselves some time.

rustbot · 2026-09-14T12:56:16Z

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 76 candidates
Random selection from 18 candidates

RalfJung · 2026-09-14T12:57:26Z

@Kobzol shouldn't the bot print a warning because this PR is not against the main branch...?

cyrgani · 2026-09-14T13:13:05Z

the warning is not shown when the PR title contains [beta: https://forge.rust-lang.org/triagebot/pr-assignment.html#exceptions-to-default-branch-warning

RalfJung · 2026-09-14T13:17:50Z

Ah :)

joshtriplett · 2026-09-14T13:34:25Z

r=me . Not because I necessarily think we should revert this, but because it's close to release, this isn't urgent, and reverting it gives us time to evaluate. So, 👍 for deferring it so we don't feel rushed.

RalfJung · 2026-09-15T12:50:50Z

Cc @BoxyUwU (are you managing the upcoming release?)

theemathas · 2026-09-15T13:20:24Z

@Mark-Simulacrum is handling the 1.99.0 release.

Mark-Simulacrum · 2026-09-15T18:48:18Z

@bors r=joshtriplett rollup=never

rust-bors · 2026-09-15T18:48:21Z

📌 Commit 6e247f2 has been approved by joshtriplett

It is now in the queue for this repository.

Zalathar · 2026-09-16T02:03:59Z

@bors p=6 (beta revert)

@joshtriplett

…cal_macros, r=joshtriplett [beta] make semicolon_in_expressions_from_non_local_macros not report-in-deps See discussion on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/Are.20we.20sure.20about.20the.20macro.20semicolon.20change.3F/with/624033497): - The lint is showing up a lot more than people seem to have expected. - "Warn" + "report-in-deps" is not a combination we usually use. - This is going to be released soon, let's buy ourselves some time. Cc @joshtriplett @petrochenkov

rust-bors · 2026-09-16T04:49:34Z

💔 Test for 8ef530a failed: CI. Failed job:

auto - dist-aarch64-llvm-mingw (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-16T04:50:05Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Zalathar · 2026-09-16T04:54:27Z

@bors retry

@joshtriplett

…cal_macros, r=joshtriplett [beta] make semicolon_in_expressions_from_non_local_macros not report-in-deps See discussion on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/Are.20we.20sure.20about.20the.20macro.20semicolon.20change.3F/with/624033497): - The lint is showing up a lot more than people seem to have expected. - "Warn" + "report-in-deps" is not a combination we usually use. - This is going to be released soon, let's buy ourselves some time. Cc @joshtriplett @petrochenkov

rust-bors · 2026-09-16T05:09:15Z

💔 Test for c7d18a9 failed: CI. Failed job:

auto - dist-aarch64-llvm-mingw (web logs, enhanced plaintext logs)

Zalathar · 2026-09-16T05:13:03Z

@bors retry

@joshtriplett

…cal_macros, r=joshtriplett [beta] make semicolon_in_expressions_from_non_local_macros not report-in-deps See discussion on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/Are.20we.20sure.20about.20the.20macro.20semicolon.20change.3F/with/624033497): - The lint is showing up a lot more than people seem to have expected. - "Warn" + "report-in-deps" is not a combination we usually use. - This is going to be released soon, let's buy ourselves some time. Cc @joshtriplett @petrochenkov

Zalathar · 2026-09-16T05:26:22Z

@bors p=10

rust-bors · 2026-09-16T05:27:05Z

💔 Test for e8298fd failed: CI. Failed job:

auto - dist-aarch64-llvm-mingw (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-16T05:30:29Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

(cherry-picked from #162765, 6e247f2)

jieyouxu · 2026-09-16T05:31:57Z

This probably needs #162650 to unblock. I rolled this PR into a combined beta backport #162838.

jieyouxu · 2026-09-16T05:42:07Z

(Tagging this beta-nominated + beta-accepted as per the zulip thread.)
@rustbot label: +beta-nominated +beta-accepted

rust-log-analyzer · 2026-09-16T06:13:14Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

…tt,jieyouxu [beta] backports * make semicolon_in_expressions_from_non_local_macros not report-in-deps (#162765) * Initialize mingw for all mingw targets (##162650) r? ghost

RalfJung · 2026-09-17T09:29:45Z

Merged in #162838.

rust-bors · 2026-09-17T09:29:48Z

This pull request was unapproved due to being closed.

make semicolon_in_expressions_from_non_local_macros not report-in-deps

6e247f2

rustbot assigned davidtwco Sep 14, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 14, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2026

rust-bors Bot mentioned this pull request Sep 16, 2026

Update cargo submodule #162823

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2026

rust-bors Bot mentioned this pull request Sep 16, 2026

[rustc_resolve] Correctly keep all reexports in ModChild::reexport_chain #162543

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2026

jieyouxu mentioned this pull request Sep 16, 2026

[beta] backports #162838

Merged

rust-bors Bot pushed a commit that referenced this pull request Sep 16, 2026

make semicolon_in_expressions_from_non_local_macros not report-in-deps

2167f4b

(cherry-picked from #162765, 6e247f2)

rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 16, 2026

RalfJung mentioned this pull request Sep 16, 2026

Tracking issue for release notes of #159700: Split non-local semicolon_in_expressions_from_macros into a separate lint #160029

Open

RalfJung closed this Sep 17, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 17, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2026

RalfJung deleted the semicolon_in_expressions_from_non_local_macros branch September 17, 2026 09:29

jieyouxu removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 17, 2026

RalfJung mentioned this pull request Sep 26, 2026

Large fallout from semicolon_in_expressions_from_non_local_macros #162872

Open

Conversation

RalfJung commented Sep 14, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 14, 2026

Uh oh!

RalfJung commented Sep 14, 2026

Uh oh!

cyrgani commented Sep 14, 2026

Uh oh!

RalfJung commented Sep 14, 2026

Uh oh!

joshtriplett commented Sep 14, 2026

Uh oh!

RalfJung commented Sep 15, 2026

Uh oh!

theemathas commented Sep 15, 2026

Uh oh!

Mark-Simulacrum commented Sep 15, 2026

Uh oh!

rust-bors Bot commented Sep 15, 2026

Uh oh!

Zalathar commented Sep 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 16, 2026

Uh oh!

rust-log-analyzer commented Sep 16, 2026

Uh oh!

Zalathar commented Sep 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 16, 2026

Uh oh!

Zalathar commented Sep 16, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Sep 16, 2026

Uh oh!

rust-bors Bot commented Sep 16, 2026

Uh oh!

rust-log-analyzer commented Sep 16, 2026

Uh oh!

jieyouxu commented Sep 16, 2026

Uh oh!

jieyouxu commented Sep 16, 2026

Uh oh!

rust-log-analyzer commented Sep 16, 2026

Uh oh!

RalfJung commented Sep 17, 2026

Uh oh!

rust-bors Bot commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

RalfJung commented Sep 14, 2026 •

edited by rustbot

Loading