c-b: Export fmaf16 now that we have an implementation - #162606
Merged
Merged
Conversation
rustbot
added
A-compiler-builtins
rustbot
added
the
T-libs
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Well that's not the error I expected to see from this change... no idea how that triggered |
Contributor
|
I can reproduce the error with |
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
tgross35
force-pushed
the
fmaf16-fallback
branch
from
September 17, 2026 06:01
e2f21ea to
893c30d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Seems like @rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
If `fmaf16` is exported, the existing version hits errors like:
error: `compiler_builtins` cannot call functions through upstream monomorphizations; encountered invalid call from `core::fmt::num::<impl core::fmt::Debug for u64>::fmt` to `core::fmt::num::imp::<impl core::fmt::Display for u64>::fmt`
--> library/core/src/fmt/num.rs:85:17
|
79 | / macro_rules! impl_Debug {
80 | | ($($T:ident)*) => {
81 | | $(
82 | | #[stable(feature = "rust1", since = "1.0.0")]
... |
85 | | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
... |
96 | | };
97 | | }
| |_- in this expansion of `impl_Debug!`
...
595 | / impl_Debug! {
596 | | i8 i16 i32 i64 i128 isize
597 | | u8 u16 u32 u64 u128 usize
598 | | }
| |_- in this macro invocation
Presumably this comes from the call to `panicking::assert_failed!` that
needs to be monomorphized. Avoid any formatting by using a plain
`debug_assert!` if we are building the crate as compiler-builtins.
LLVM doesn't currently emit this but probably should, and this is valuable as a fallback in any case.
tgross35
force-pushed
the
fmaf16-fallback
branch
from
September 17, 2026 07:10
893c30d to
362d116
Compare
Contributor
|
Nice @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 17, 2026
…tdev c-b: Export `fmaf16` now that we have an implementation tracking issue: rust-lang#116909 LLVM doesn't currently emit this but probably should, and this is valuable as a fallback in any case.
This was referenced Sep 17, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 18, 2026
…uwer Rollup of 10 pull requests Successful merges: - #161987 (fix `is_single_fp_element` for `s390x` and `x86`) - #162366 (Replace hard linked `metadata.rmeta` with a copy when finalizing the incremental compilation session dir fails) - #162552 (RISC-V: Add Zmmul target feature) - #162602 (Ensure concurrent rustc instances in the same process correctly lock the session dir) - #162885 (Remove one remaining use of `Level::Help`) - #162606 (c-b: Export `fmaf16` now that we have an implementation) - #162817 (rustc_{codegen_,}llvm: adapt to new ThreadModel API) - #162860 (offload: add libLLVM rpath for libomptarget) - #162895 (Avoid derive edits on macro-generated types) - #162899 (Error on invalid placements of the `cfi_encoding` attribute.)
pull Bot
pushed a commit
to xtqqczze/rust-lang-rust-analyzer
that referenced
this pull request
Sep 21, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#161987 (fix `is_single_fp_element` for `s390x` and `x86`) - rust-lang/rust#162366 (Replace hard linked `metadata.rmeta` with a copy when finalizing the incremental compilation session dir fails) - rust-lang/rust#162552 (RISC-V: Add Zmmul target feature) - rust-lang/rust#162602 (Ensure concurrent rustc instances in the same process correctly lock the session dir) - rust-lang/rust#162885 (Remove one remaining use of `Level::Help`) - rust-lang/rust#162606 (c-b: Export `fmaf16` now that we have an implementation) - rust-lang/rust#162817 (rustc_{codegen_,}llvm: adapt to new ThreadModel API) - rust-lang/rust#162860 (offload: add libLLVM rpath for libomptarget) - rust-lang/rust#162895 (Avoid derive edits on macro-generated types) - rust-lang/rust#162899 (Error on invalid placements of the `cfi_encoding` attribute.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #116909
LLVM doesn't currently emit this but probably should, and this is valuable as a fallback in any case.
r? @folkertdev