Drop host tools from `i686-pc-windows-msvc` by mati865 · Pull Request #162288 · rust-lang/rust

mati865 · 2026-09-04T10:27:29Z

I have collapsed two test jobs into one because the second one no longer runs any tests: #162288 (comment)

mati865 · 2026-09-04T10:27:59Z

@bors try jobs=i686-msvc

Drop host tools from `i686-pc-windows-msvc` try-job: *i686-msvc*

rust-bors · 2026-09-04T12:24:08Z

☀️ Try build successful (CI)
Build commit: 6184e26 (6184e263405335f8eb664abc115de9e4826b1d1a)
Base parent: 71238e2 (71238e21fc55e73ab3aad8c9f79fed7a47a179e1)

mati865 · 2026-09-04T12:47:57Z

@bors try jobs=*i686-msvc

Drop host tools from `i686-pc-windows-msvc` try-job: *i686-msvc

rust-bors · 2026-09-04T15:25:19Z

☀️ Try build successful (CI)
Build commit: 95fafdf (95fafdf210a92fcb9a1a0c36b7814f419777713e)
Base parent: b924f94 (b924f94129bce80f36dd9f08bb78dd5393fe196e)

rustbot · 2026-09-08T14:53:59Z

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

jieyouxu

One nit
@rustbot author

View changes since this review

jieyouxu

Thanks!
@bors r+ rollup=never note="changes CI jobs"

View changes since this review

rust-bors · 2026-09-09T12:03:27Z

📌 Commit 23632e9 has been approved by jieyouxu

It is now in the queue for this repository.

mati865 · 2026-09-09T12:35:48Z

TIL about note Bors command 😮

rust-bors · 2026-09-09T20:04:23Z

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 3m 46s
Pushing 32ffad3 to main...

github-actions · 2026-09-09T20:07:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 88acefd (parent) -> 32ffad3 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 32ffad32f4cdad86624f6ec46737f70d98a9a88d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-i686-msvc: 2h 19m -> 42m 1s (-70.0%)
test-x86_64-gnu-stdlib-semver-check: 17m 59s -> 11m 30s (-36.1%)
test-x86_64-gnu-gcc-core-tests: 18m 41s -> 11m 58s (-36.0%)
dist-ohos-aarch64: 58m 12s -> 1h 18m (+35.1%)
test-pr-check-1: 44m 1s -> 29m 12s (-33.7%)
dist-riscv64-linux-gnu: 1h 11m -> 1h 35m (+32.5%)
test-x86_64-gnu-parallel-frontend: 2h 3m -> 1h 24m (-31.9%)
test-x86_64-gnu: 2h 41m -> 1h 49m (-31.8%)
test-x86_64-gnu-llvm-21-1: 1h 3m -> 43m 34s (-31.4%)
test-x86_64-gnu-nopt: 1h 47m -> 2h 20m (+30.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-09-09T21:08:01Z

Finished benchmarking commit (32ffad3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.8%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	3.1%	[2.0%, 4.1%]	2
Improvements ✅ (primary)	-1.0%	[-2.7%, -0.5%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-2.7%, 0.4%]	6

Cycles

Results (primary 0.3%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 3.1%]	8
Regressions ❌ (secondary)	2.9%	[2.1%, 3.6%]	2
Improvements ✅ (primary)	-0.6%	[-1.1%, -0.4%]	9
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	0.3%	[-1.1%, 3.1%]	17

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 480.225s -> 481.963s (0.36%)
Artifact size: 403.27 MiB -> 403.29 MiB (0.00%)

…skip, r=jieyouxu Revert "Skip rustc book on i686" Reverts rust-lang#158379 This should not be needed anymore since rust-lang#162288 merged

…youxu Revert "Skip rustc book on i686" Reverts #158379 This should not be needed anymore since #162288 merged

…skip, r=jieyouxu Revert "Skip rustc book on i686" Reverts rust-lang#158379 This should not be needed anymore since rust-lang#162288 merged

RalfJung · 2026-09-10T05:59:27Z

FWIW https://doc.rust-lang.org/nightly/rustc/platform-support.html still lists this as tier 1 with host tools.

jieyouxu · 2026-09-10T06:02:13Z

🤦 I always forget... I'll send a follow-up.

jieyouxu · 2026-09-10T06:27:15Z

Follow-up: #162577
Apparenly I also forget about target metadata...

Rollup merge of #162553 - JonathanBrouwer:revert-rustc-book-skip, r=jieyouxu Revert "Skip rustc book on i686" Reverts #158379 This should not be needed anymore since #162288 merged

Drop host tools from `i686-pc-windows-msvc` Implements [RFC 3999](rust-lang/rfcs#3999). Fixes rust-lang/rust#158378 I have collapsed two test jobs into one because the second one no longer runs any tests: rust-lang/rust#162288 (comment)

…r=khyperia Fix `i686-pc-windows-msvc` platform support docs and target spec metadata ## Summary Follow-up fixes to rust-lang#162288. - Fix an outdated claim that all T1 targets have host tools, since `i686-pc-windows-msvc` no longer does. - Remove a duplicate Tier 1 section. - Put `i686-pc-windows-msvc` under its own Tier 1 without host tools ## Context * `i686-pc-windows-msvc` Tier 1 (with host tools) => Tier 1 (without host tools) RFC: rust-lang/rfcs#3999 * cc rust-lang#158378

Rollup merge of #162577 - jieyouxu:i686-msvc-no-host-tools, r=khyperia Fix `i686-pc-windows-msvc` platform support docs and target spec metadata ## Summary Follow-up fixes to #162288. - Fix an outdated claim that all T1 targets have host tools, since `i686-pc-windows-msvc` no longer does. - Remove a duplicate Tier 1 section. - Put `i686-pc-windows-msvc` under its own Tier 1 without host tools ## Context * `i686-pc-windows-msvc` Tier 1 (with host tools) => Tier 1 (without host tools) RFC: rust-lang/rfcs#3999 * cc #158378

Drop host tools from `i686-pc-windows-msvc` Implements [RFC 3999](rust-lang/rfcs#3999). Fixes rust-lang/rust#158378 I have collapsed two test jobs into one because the second one no longer runs any tests: rust-lang/rust#162288 (comment)

… toolchains Rust 1.100 dropped host tools for both i686-pc-windows-msvc (RFC 3999, rust-lang/rust#162288) and i686-pc-windows-gnu, so the nightly channel no longer has a `nightly-i686-pc-windows-{msvc,gnu}` toolchain to install and those jobs have been failing at the "Install Rust" step: error: target 'i686-pc-windows-msvc' not found in channel. Keep the 32-bit coverage by installing the targets on the x86_64 host toolchain and setting CARGO_BUILD_TARGET, so every cargo invocation in the job builds for i686 while the resulting binaries still run natively on the 64-bit runner. This is how rust-lang's own CI tests these targets now. The MSVC toolchain on the runner already links 32-bit code, but the preinstalled MinGW is 64-bit only, so the gnu target gets its linker from the runner's MSYS2 via pacman. Assisted-by: Claude Fable 5.1 (claude-fable-5-1) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcsZ88kqELsUqZx82Shtkj

… toolchains Rust 1.100 dropped host tools for both i686-pc-windows-msvc (RFC 3999, rust-lang/rust#162288) and i686-pc-windows-gnu, so the nightly channel no longer has a `nightly-i686-pc-windows-{msvc,gnu}` toolchain to install and those jobs have been failing at the "Install Rust" step: error: target 'i686-pc-windows-msvc' not found in channel. Keep the 32-bit coverage by installing the targets on the x86_64 host toolchain and setting CARGO_BUILD_TARGET, so every cargo invocation in the job builds for i686 while the resulting binaries still run natively on the 64-bit runner. This is how rust-lang's own CI tests these targets now. The MSVC toolchain on the runner already links 32-bit code, but the preinstalled MinGW is 64-bit only, so the gnu target gets its linker from the runner's MSYS2 via pacman. Assisted-by: Claude Fable 5.1 (claude-fable-5-1) Claude-Session: https://claude.ai/code/session_01TcsZ88kqELsUqZx82Shtkj

Rust 1.100 dropped host tools for both i686 Windows targets (RFC 3999, rust-lang/rust#162288), so the nightly channel no longer has a `nightly-i686-pc-windows-{msvc,gnu}` toolchain to install and those jobs have been failing at the "Install Rust" step: error: target 'i686-pc-windows-msvc' not found in channel. Keep the 32-bit MSVC coverage by installing the target on the x86_64 host toolchain and setting CARGO_BUILD_TARGET, so every cargo invocation in the job builds for i686 while the binaries still run natively on the 64-bit runner. This is how rust-lang's own CI tests the target now. i686-pc-windows-gnu is dropped instead. It is only Tier 2 without host tools upstream, the runner ships no 32-bit MinGW, and the one from MSYS2 fails to link without any diagnostics, so it is not worth the effort. Assisted-by: Claude Fable 5.1 (claude-fable-5-1)

Drop host tools from `i686-pc-windows-msvc` Implements [RFC 3999](rust-lang/rfcs#3999). Fixes rust-lang/rust#158378 I have collapsed two test jobs into one because the second one no longer runs any tests: rust-lang/rust#162288 (comment)

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026

Auto merge of #162288 - mati865:i686-msvc-no-host, r=<try>

6184e26

Drop host tools from `i686-pc-windows-msvc` try-job: *i686-msvc*

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026

Auto merge of #162288 - mati865:i686-msvc-no-host, r=<try>

95fafdf

Drop host tools from `i686-pc-windows-msvc` try-job: *i686-msvc

This comment has been minimized.

Sign in to view

mati865 force-pushed the i686-msvc-no-host branch from 742d2e0 to 7318db6 Compare September 7, 2026 10:29

jieyouxu self-assigned this Sep 8, 2026

mati865 marked this pull request as ready for review September 8, 2026 14:53

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 8, 2026

jieyouxu reviewed Sep 9, 2026

View reviewed changes

Comment thread src/ci/github-actions/jobs.yml Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2026

mati865 added 2 commits September 9, 2026 12:21

Drop host tools from i686-pc-windows-msvc

e240cdf

Merge i686-msvc test jobs into one

23632e9

mati865 force-pushed the i686-msvc-no-host branch from 7318db6 to 23632e9 Compare September 9, 2026 10:21

jieyouxu approved these changes Sep 9, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2026

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2026

rust-bors Bot merged commit 32ffad3 into rust-lang:main Sep 9, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Sep 9, 2026

rust-bors Bot mentioned this pull request Sep 9, 2026

[EXPERIMENT] Pin cdb to version 10.0.26100 #158746

Draft

JonathanBrouwer mentioned this pull request Sep 9, 2026

Revert "Skip rustc book on i686" #162553

Merged

rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026

Auto merge of #162553 - JonathanBrouwer:revert-rustc-book-skip, r=jie…

87547e8

…youxu Revert "Skip rustc book on i686" Reverts #158379 This should not be needed anymore since #162288 merged

RalfJung mentioned this pull request Sep 10, 2026

Automatic Rustup rust-lang/miri#5313

Merged

jieyouxu mentioned this pull request Sep 10, 2026

Fix i686-pc-windows-msvc platform support docs and target spec metadata #162577

Merged

zeenix mentioned this pull request Sep 18, 2026

ci: Cross-compile for i686-pc-windows-msvc and drop i686-pc-windows-gnu smol-rs/polling#269

Merged

Uh oh!

Conversation

mati865 commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mati865 commented Sep 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 4, 2026

Uh oh!

mati865 commented Sep 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 4, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 8, 2026

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 9, 2026

Uh oh!

mati865 commented Sep 9, 2026

Uh oh!

rust-bors Bot commented Sep 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 9, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

RalfJung commented Sep 10, 2026

Uh oh!

jieyouxu commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mati865 commented Sep 4, 2026 •

edited

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu commented Sep 10, 2026 •

edited

Loading

jieyouxu commented Sep 10, 2026 •

edited

Loading