Skip to content

Rename dlltool helper function - #161701

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mati865:dlltool-helper-rename
Aug 26, 2026
Merged

Rename dlltool helper function#161701
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mati865:dlltool-helper-rename

Conversation

@mati865

@mati865 mati865 commented Aug 24, 2026

Copy link
Copy Markdown
Member

It doesn't check for MinGW toolchain (windows-gnu or windows-gnullvm), but windows-gnu only. All the callsites use that helper to decide whether dlltool should be used.

r? @bjorn3

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2026
@bjorn3

bjorn3 commented Aug 26, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8f302fb has been approved by bjorn3

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 26, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150067 (Alloc `String::retain` optimization)
 - #153973 (std::process: fix UEFI ExitStatus::code() silent truncation of error …)
 - #161690 (Deny #[inline] on EII declarations)
 - #161701 (Rename dlltool helper function)
@rust-bors
rust-bors Bot merged commit f7f990f into rust-lang:main Aug 26, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 26, 2026
Rollup merge of #161701 - mati865:dlltool-helper-rename, r=bjorn3

Rename dlltool helper function

It doesn't check for MinGW toolchain (`windows-gnu` or `windows-gnullvm`), but `windows-gnu` only. All the callsites use that helper to decide whether dlltool should be used.

r? @bjorn3
@mati865
mati865 deleted the dlltool-helper-rename branch August 26, 2026 19:57
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 27, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#150067 (Alloc `String::retain` optimization)
 - rust-lang/rust#153973 (std::process: fix UEFI ExitStatus::code() silent truncation of error …)
 - rust-lang/rust#161690 (Deny #[inline] on EII declarations)
 - rust-lang/rust#161701 (Rename dlltool helper function)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants