Repository navigation
Enable tests/debuginfo on test-aarch64-gnu-llvm-21 - #161574
Merged
Merged
Conversation
rustbot
added
A-CI
Contributor
Author
|
oh, it runs on aarch64 not x86_64 |
Contributor
Author
|
hmm, lldb was installed but the tests were still ignored: Relevant logsLLDB discovery is enabled as well: |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
huh, double interesting.
|
This comment has been minimized.
This comment has been minimized.
Kobzol
reviewed
Aug 24, 2026
| # Ideally, we should later change this to provide the paths explicitly | ||
| RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set build.gdb=discover" | ||
| RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set build.lldb=discover" | ||
| RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set build.lldb=lldb" |
Member
There was a problem hiding this comment.
I think that we shouldn't do it across all CI jobs until we are sure what LLDB versions are installed and where. And even then I would perhaps consider opting into specific lldb paths on the individual jobs, to ensure that we don't use some host pre-installed LLDB by accident.
Contributor
Author
|
If i'm not mistaken, even with this patch there would only be a single version of LLDB tested (well, technically 2 if you count apple's LLDB). AFAIK, the windows test runners don't test LLDB at all, and none of the other So this patch would essentially be the first non-apple runner to run the LLDB tests, and set our sole supported version of LLVM LLDB to 21.X.X. The updated tests are hard-gated by LLDB 21 is convenient because it's what is currently run in PR CI (whereas the LLVM 22 runners are only run via bors). |
Member
We can easily change that! And in fact we should bump LLVM tested on PR CI to 22, the fact that we still use 21 anywhere on CI is mostly just an artifact of depending on Fedora's release cadence. Ok, I guess that saying that we support only 21 is good for now. The main thing that I want to ensure is that if we claim to support something, we test it on CI. |
This comment has been minimized.
This comment has been minimized.
Walnut356
changed the title
tests/debuginfo on x86_64-gnu-llvm-21tests/debuginfo on aarch64-gnu-llvm-21
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
And here is the relevant output from |
Contributor
Author
|
This PR-CI run is expected to fail. I'm just checking how easy it is to detect that we're in CI, and how the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Walnut356
marked this pull request as ready for review
August 30, 2026 09:38
rustbot
added
S-waiting-on-review
This was referenced Aug 31, 2026
This comment has been minimized.
This comment has been minimized.
Walnut356
force-pushed
the
linux_lldb
branch
from
September 14, 2026 07:12
a0cf543 to
e12a74e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jieyouxu
approved these changes
Sep 23, 2026
Member
There was a problem hiding this comment.
Thanks
@bors r+ rollup=never note="enabling lldb on aarch64-gnu-llvm-21"
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jieyouxu
changed the title
tests/debuginfo on aarch64-gnu-llvm-21tests/debuginfo on test-aarch64-gnu-llvm-21
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a92214c (parent) -> 1a8fa55 (this PR) Test differencesShow 190 test diffsStage 2
(and 86 additional test diffs) Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1a8fa555801329bd0e803d7384b5a21191c61f30 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (1a8fa55): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 7.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 501.272s -> 490.745s (-2.10%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
This should allow
tests/debuginfoto run the LLDB tests in PR CI. This should runbasic-typesandpretty-stdwhich both containreprdirectives.r? @jieyouxu @Kobzol