Add regression test for $-prefixed fragment specifier in repetition#159114
Open
asuto15 wants to merge 1 commit into
Open
Add regression test for $-prefixed fragment specifier in repetition#159114asuto15 wants to merge 1 commit into
asuto15 wants to merge 1 commit into
Conversation
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157157.
The diagnostic was fixed in #155643, but the existing test only covers an accidental
$before a fragment specifier at the top level of a matcher.This adds the equivalent case inside a repetition.
The new case reuses
$test:$ttfrom the adjacent test so that repetition nesting is the only difference between the two cases.Tested with:
./x test tests/ui/macros/macro-missing-fragment.rsThis is my first contribution to this repository, so please let me know if I have missed any conventions or required steps or should make any additional changes.