Skip to content

Add regression test for $-prefixed fragment specifier in repetition#159114

Open
asuto15 wants to merge 1 commit into
rust-lang:mainfrom
asuto15:macro-fragment-regression
Open

Add regression test for $-prefixed fragment specifier in repetition#159114
asuto15 wants to merge 1 commit into
rust-lang:mainfrom
asuto15:macro-fragment-regression

Conversation

@asuto15

@asuto15 asuto15 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #157157.

The diagnostic was fixed in #155643, but the existing test only covers an accidental $ before a fragment specifier at the top level of a matcher.
This adds the equivalent case inside a repetition.

The new case reuses $test:$tt from the adjacent test so that repetition nesting is the only difference between the two cases.

Tested with:

  • ./x test tests/ui/macros/macro-missing-fragment.rs

This is my first contribution to this repository, so please let me know if I have missed any conventions or required steps or should make any additional changes.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@chenyukang

Copy link
Copy Markdown
Member

Thanks!
@bors r=chenyukang

@rust-bors

rust-bors Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d905d0a has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extraneous $ in macro by example matcher produces suggestion for nonsensica, syntactically invalid fix

4 participants