Skip to content

Migrate UI tests - #154386

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lokirithm:migrate-ui-tests
Mar 26, 2026
Merged

Migrate UI tests#154386
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lokirithm:migrate-ui-tests

Conversation

@lokirithm

@lokirithm lokirithm commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

In this pull request, I am migrating the following files and adding a comment at the top, including a link to the issue they were regression tests for:

  • tests/ui/issues/issue-4735.rs ➝ tests/ui/drop/drop-noncopyable-raw-pointer.rs
  • tests/ui/issues/issue-17734.rs ➝ tests/ui/codegen/box-str-drop-glue.rs

r? Kivooeo

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2026
@lqd

lqd commented Mar 25, 2026

Copy link
Copy Markdown
Member

Also please squash the commits, thanks!

@Kivooeo

Kivooeo commented Mar 25, 2026

Copy link
Copy Markdown
Member

Here it would be preferable to squash third into second commit

@lokirithm
Add issue link at the top in files tests/ui/codegen/box-str-drop-glue…
ff29b41 
….rs and tests/ui/drop/drop-noncopyable-raw-pointer.rs
@Kivooeo

Kivooeo commented Mar 25, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ff29b41 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 25, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Mar 26, 2026
@bors
Auto merge of #154390 - JonathanBrouwer:rollup-y369aHY, r=JonathanBro…
6d8bc65 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #153068 (Require avxvnni for avx10.2)
 - #154359 (Add regression test for #154189)
 - #154386 (Migrate UI tests)
@rust-bors
rust-bors Bot merged commit c8d729b into rust-lang:main Mar 26, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 26, 2026
@lokirithm
lokirithm deleted the migrate-ui-tests branch April 8, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lokirithm @lqd @Kivooeo @rustbot