Repository navigation
Add default_field_values entry to unstable book - #134855
Conversation
|
rustbot has assigned @GuillaumeGomez. Use |
This comment has been minimized.
This comment has been minimized.
7b7041b to
62c6631
Compare
This comment has been minimized.
This comment has been minimized.
62c6631 to
5693f3a
Compare
|
IIUC I think this should be assigned to someone actually updating the book, right? cc @carols10cents |
@apiraino that doesn't seem to be the case. A quick search pulls up these recent PRs:
This is the unstable book, which is completely unrelated (AIUI) to The Book. I wouldn't want to leave this PR with no assignee. @jieyouxu, I see that you reviewed at least one of the PRs above, could you take a look? |
|
I could. r? jieyouxu |
commented
Jan 8, 2025
Oh I'm sorry, this is the key info I was missing, it was probably assigned to him due to this. Anyway, no need to assign to someone else :) the PR could have being reassigned to Guillaume (currently on leave). thanks for clarifying and sorry for the confusion |
| The tracking issue for this feature is: [#132162] | ||
|
|
||
| [#132162]: https://github.com/rust-lang/rust/issues/132162 |
There was a problem hiding this comment.
Question: should we also link the RFC directly here to save a layer of indirection?
commented
Jan 8, 2025
@apiraino I believe that usually the team that the feature's impl is primarily concerned with will review the feature's unstable book PRs. In this case, compiler. |
5693f3a to
13e8876
Compare
commented
Jan 9, 2025
|
@bors r=jieyouxu |
commented
Jan 9, 2025
commented
Jan 9, 2025
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
commented
Jan 9, 2025
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Tracking issue: #132162
RFC: https://github.com/rust-lang/rfcs/blob/master/text/3681-default-field-values.md