Skip to content

std::thread::available_parallelism merging linux/android/freebsd version - #120589

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
devnexen:cpuaff_fbsd_upd
Sep 23, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
devnexen:cpuaff_fbsd_upd

Conversation

@devnexen

@devnexen devnexen commented Feb 2, 2024 •

Copy link
Copy Markdown
Contributor

View all comments

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

@rustbot

rustbot commented Feb 2, 2024

Copy link
Copy Markdown
Collaborator

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 2, 2024
@rust-log-analyzer

This comment has been minimized.

Comment thread library/std/src/sys/pal/unix/thread.rs Outdated
@m-ou-se

m-ou-se commented Feb 8, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 0bfcafd has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024
@Nadrieril

Copy link
Copy Markdown
Member

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#113026 (Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120590 (Remove unused args from functions)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120693 (Invert diagnostic lints.)
 - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`)
 - rust-lang#120750 (No need to take `ImplTraitContext` by ref)
 - rust-lang#120765 (Reorder diagnostics API)
 - rust-lang#120772 (Remove myself from review rotation.)
 - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)

Failed merges:

 - rust-lang#120782 (Fix mir pass ICE in the presence of other errors)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120308 (core/time: avoid divisions in Duration::new)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120672 (std::thread update freebsd stack guard handling.)
 - rust-lang#120693 (Invert diagnostic lints.)
 - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`)
 - rust-lang#120806 (Clippy subtree update)
 - rust-lang#120809 (Use `transmute_unchecked` in `NonZero::new`.)
 - rust-lang#120817 (Fix more `ty::Error` ICEs in MIR passes)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2024
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120584 (For a rigid projection, recursively look at the self type's item bounds to fix the `associated_type_bounds` feature)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120629 (Move some test files)
 - rust-lang#120846 (Update jobserver-rs to 0.1.28)
 - rust-lang#120850 (ast_lowering: Fix regression in `use ::{}` imports.)
 - rust-lang#120853 (Avoid a collection and iteration on empty passes)

Failed merges:

 - rust-lang#120549 (modify alias-relate to also normalize ambiguous opaques)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr

Copy link
Copy Markdown
Member

@bors r- rollup=never
linking failure
#120861 (comment)

@bors

bors commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2025
@devnexen

devnexen commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

oh I see, the freebsd ABI had not been updated, so yes no chance to work as is.

@Enselic

Enselic commented Dec 5, 2025

Copy link
Copy Markdown
Member

Ok, let's marked as S-blocked for now. Just ping when this can be tried again.

@Enselic Enselic added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025
@jhpratt

jhpratt commented Jan 4, 2026

Copy link
Copy Markdown
Member

@bors r- (sync)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 4, 2026
@Enselic Enselic added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. labels Jan 5, 2026
@rust-bors

This comment has been minimized.

@clarfonthey

Copy link
Copy Markdown
Contributor

Looks like this needs a rebase; what's the status of this, @devnexen @Enselic? I assume that after a year the issues have sort of settled out.

@rustbot

rustbot commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@clarfonthey

Copy link
Copy Markdown
Contributor

@rustbot author

(Going to take that as mostly a yes?)

@devnexen

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@clarfonthey

Copy link
Copy Markdown
Contributor

@bors try jobs=*-freebsd

cc @Enselic if you want to do review, but since this does have tests being tier 2, I would be comfortable just merging myself if you'd prefer.

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 4ac1a43 (4ac1a43dca8937dae0486838dc31a7df3a8b99b7)
Base parent: 52d0fd8 (52d0fd8771cf35f8fdb31a41a96d545cebb74931)

@tgross35

Copy link
Copy Markdown
Member

Please squash the formatting commit too. Also, not that it matters, but there's a random a at the end of d501f72

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer
with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@clarfonthey

Copy link
Copy Markdown
Contributor

@bors r+ r=m-ou-se,clarfonthey rollup

I think this should be okay.

@rust-bors

rust-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9f208cb has been approved by clarfonthey

It is now in the queue for this repository.

@Enselic

Enselic commented Sep 23, 2026

Copy link
Copy Markdown
Member

Feel free to take over this one!

r? clarfonthey

@RalfJung

Copy link
Copy Markdown
Member

This caused a regression in Miri: rust-lang/miri#5344.

I can't yet tell if this is a Miri bug or a bug in std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-android Operating system: Android O-freebsd Operating system: FreeBSD O-linux Operating system: Linux O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.