Add private NonZero<T> type alias. - #119990
Merged
Merged
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
reitermarkus
force-pushed
the
nonzero-type-alias
branch
from
January 15, 2024 11:50
988772d to
d0afa6d
Compare
Contributor
Author
|
r? @dtolnay |
reitermarkus
force-pushed
the
nonzero-type-alias
branch
from
January 15, 2024 12:44
d0afa6d to
f760223
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
klensy
reviewed
Jan 15, 2024
klensy
reviewed
Jan 15, 2024
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118361 (stabilise bound_map) - rust-lang#119816 (Define hidden types in confirmation) - rust-lang#119900 (Inline `check_closure`, simplify `deduce_sig_from_projection`) - rust-lang#119969 (Simplify `closure_env_ty` and `closure_env_param`) - rust-lang#119990 (Add private `NonZero<T>` type alias.) - rust-lang#119998 (Update books) - rust-lang#120002 (Lint `overlapping_ranges_endpoints` directly instead of collecting into a Vec) - rust-lang#120018 (Don't allow `.html` files in `tests/mir-opt/`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2024
Rollup merge of rust-lang#119990 - reitermarkus:nonzero-type-alias, r=dtolnay Add private `NonZero<T>` type alias. According to step 2 suggested in rust-lang#100428 (review). This adds a private type alias for `NonZero<T>` so that some parts of the code can already start using `NonZero<T>` syntax. Using `NonZero<T>` for `convert` and other parts which implement `From` doesn't work while it is a type alias, since this results in conflicting implementations.
20 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to step 2 suggested in #100428 (review).
This adds a private type alias for
NonZero<T>so that some parts of the code can already start usingNonZero<T>syntax.Using
NonZero<T>forconvertand other parts which implementFromdoesn't work while it is a type alias, since this results in conflicting implementations.