Skip to content

Replace LLVM any_isa with any_cast - #110523

Merged
bors merged 1 commit into
rust-lang:masterfrom
ecnelises:llvm_isa_fix
Apr 22, 2023
Merged

bors merged 1 commit into
rust-lang:masterfrom
ecnelises:llvm_isa_fix

Conversation

@ecnelises

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2023
Comment thread compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp Outdated
@cuviper

cuviper commented Apr 20, 2023

Copy link
Copy Markdown
Member

Thanks!

@bors r+

@bors

bors commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 1a44694 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@bors

bors commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a44694 with merge 263e8f09aeed2b793c0b9a599eccdd5d801dcc77...

@bors

bors commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2023
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Session terminated, killing shell...[RUSTC-TIMING] memchr test:false 1.275
  network time: Sat, 22 Apr 2023 17:58:28 GMT
== end clock drift check ==
[RUSTC-TIMING] rustc_demangle test:false 2.068
 ...killed.
time="2023-04-22T17:58:29Z" level=error msg="error waiting for container: unexpected EOF"
##[error]The operation was canceled.
Terminate orphan process: pid (2011) (node)
Terminate orphan process: pid (2021) (python3)

@cuviper

cuviper commented Apr 22, 2023

Copy link
Copy Markdown
Member

Seems like a spurious failure?
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2023
@bors

bors commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a44694 with merge b628260...

@bors

bors commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing b628260 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2023
@bors
bors merged commit b628260 into rust-lang:master Apr 22, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 22, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b628260): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.8% [-4.8%, -4.8%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants