Skip to content

Run compiler doctests in CI #99144

Closed
#106621
Closed
Run compiler doctests in CI#99144
#106621
Assignees
CarsonV
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Description

@jyn514
jyn514
opened on Jul 11, 2022

Right now these are only ever run locally, which means they often break. We should run these in CI.

See #99144 (comment) for mentoring instructions.

Originally posted by @jyn514 in #95994 (comment)

Activity

  1. jyn514
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Jul 11, 2022

  2. jyn514 commented on Jul 11, 2022

    @jyn514
    jyn514
    on Jul 11, 2022 · Hidden as outdated
    Author

  3. Mark-Simulacrum commented on Jul 11, 2022

    @Mark-Simulacrum
    Mark-Simulacrum
    on Jul 11, 2022 · Hidden as outdated

  4. reez12g commented on Jul 11, 2022

    @reez12g
    reez12g
    on Jul 11, 2022
    Contributor

    @rustbot claim

  5. rustbot
    assigned
    reez12g
    on Jul 11, 2022

  6. jyn514 commented on Jul 11, 2022

    @jyn514
    jyn514
    on Jul 11, 2022
    MemberAuthor

    @reez12g see #99040 for an example of something similar

  7. bors
    added a commit that references this issue on Oct 6, 2022

    Auto merge of rust-lang#99324 - reez12g:issue-99144, r=jyn514

    0152393

  8. reez12g commented on Oct 6, 2022

    @reez12g
    reez12g
    on Oct 6, 2022
    Contributor

    The remaining crates that need to be fixed are

    • rustc_ast_lowering: claimed by @GentBinaku
    • rustc_builtin_macros
    • rustc_expand
    • rustc_infer: claimed by @CarsonV
    • rustc_middle
    • rustc_query_impl

    Here's steps to fix these.

    1. Remove doctest=false in the target Calgo.toml.
      e.g. this
    2. Run the test locally.
      e.g. python3 x.py test compiler/rustc_ast_lowering --stage 0
    3. Fix the errors.

    @jyn514
    I couldn't edit the description, so I left it as a comment.

  9. reez12g
    removed their assignment
    on Oct 6, 2022
  10. jyn514
    added
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Oct 6, 2022

  11. nakatomotoi commented on Oct 7, 2022

    @nakatomotoi
    nakatomotoi
    on Oct 7, 2022

    @rustbot claim

  12. rustbot
    assigned
    nakatomotoi
    on Oct 7, 2022

  13. 12 remaining items

  14. rustbot
    unassigned
    geikoh
    on Nov 30, 2022

  15. CarsonV commented on Dec 24, 2022

    @CarsonV
    CarsonV
    on Dec 24, 2022
    Contributor

    @rustbot claim

  16. rustbot commented on Dec 24, 2022

    @rustbot
    rustbot
    on Dec 24, 2022
    Collaborator

    Error: Malformed triagebot.toml in default branch.
    newline in string found at line 345 column 53

    Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

  17. CarsonV commented on Dec 25, 2022

    @CarsonV
    CarsonV
    on Dec 25, 2022
    Contributor

    @rustbot claim

  18. rustbot
    assigned
    CarsonV
    and unassigned
    technetos
    on Dec 25, 2022

  19. lokera666 commented on Dec 31, 2022

    @lokera666
    lokera666
    on Dec 31, 2022

    @rustbotreclamar

  20. jyn514 commented on Dec 31, 2022

    @jyn514
    jyn514
    on Dec 31, 2022
    MemberAuthor

    Ok, this is not working. If you want to work on this issue, please also say which crate you are working on; doing one crate at a time is fine. It's ok to work on crates that haven't yet been claimed.

  21. GentBinaku commented on Dec 31, 2022

    @GentBinaku
    GentBinaku
    on Dec 31, 2022

    @jyn514 I have been working on the first crate rustc_ast_lowering; I will finish this week I will do a Pull request

  22. CarsonV commented on Jan 4, 2023

    @CarsonV
    CarsonV
    on Jan 4, 2023
    Contributor

    rustc_query_impl is done, claiming rustc_infer next while Gent works on ast_lowering

  23. matthiaskrgr
    added a commit that references this issue on Jan 4, 2023

    Rollup merge of rust-lang#106436 - CarsonV:doctest_query_impl, r=jyn514

    4e590b3
  24. bors
    added a commit that references this issue on May 8, 2023

    Auto merge of rust-lang#106621 - ozkanonur:enable-elided-lifetimes-fo…

    ea0c22e
  25. bors
    closed this as completedin ea0c22eon May 8, 2023
  26. RalfJung
    added a commit that references this issue on Apr 20, 2024

    Auto merge of #99324 - reez12g:issue-99144, r=jyn514

    efa1870
  27. RalfJung
    added a commit that references this issue on Apr 27, 2024

    Auto merge of #99324 - reez12g:issue-99144, r=jyn514

    97085cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions