{Rc,Arc}::new_cyclic documentation is insufficient

As I reported in the i.r-l.o prerelease thread, the documentation of the new(ly stabilized) Rc and Arc method new_cyclic could really use some elaboration before the 1.60 release.

I'm quite familiar with refcounting, strong/weak refs, etc. but just from the doc, I have no idea what problem the new method solves exactly, when I should use it, why the closure is needed, how the closure argument seems to come from "thin air", and what the closure should return.

s/new_acyclic/new_cyclic

Argh, thanks. Could've sworn I specifically double-checked that I wrote "cyclic"…

Problem the method solves: constructing a T which holds a Weak<T> pointer to itself.
When you should use it: when you need to do the above. Previously you'd construct with e.g. Weak::dangling and then mutate the value (via e.g. get_mut) to fix up the self references.
Where the closure argument comes from: essentially, the point of new_cyclic is that the place is allocated first, with strong=0, weak=1. The place has no data yet (you're constructing the value to place there), but is in the "zombie" state where it has weak references but no data.
Why the closure is needed: the place needs to be "finished" once the value is created. In theory, you could "recover" any zombie weak, but for the most case, Rust wants to pretend that a "zombie" Weak and a dangling Weak are equivalent.
What the closure should return: the closure returns the object to place in the reference counted place. After you've constructed the object, the reference count is "activated" and the object is accessable by (clones of) the weak pointer given to the constructor closure.

For the most part, new_cyclic exists to construct enable_shared_from_this style objects more easily, which is what the example demonstrates. It can be used for other use cases, but this is the primary motivating example.

I'm biased because I know what new_cyclic is used for, so the existing documentation is enough. The docs aren't going to be changed for 1.60, but if you (or anyone) can improve the docs (with the above information or otherwise), PRs to do so are welcome!

I agree I had to read the documentation a few times to understand what this does.

Hi! Just a quick note that changing the documentation for the Rust 1.60.0 release itself will likely not be possible, that'd require a full release rebuild.

@CAD97

I'm sending a PR with explanations provided by @CAD97 so that it'll at least be in the next release.

@pietroalbini Why do you need a full release rebuild btw? Isn't it possible to regen the docs without rebuilding everything like the --keep-stage option on rustc?

I opened #95843. Feedback is very welcome. :)

Why do you need a full release rebuild btw? Isn't it possible to regen the docs without rebuilding everything like the --keep-stage option on rustc?

Our release tooling only supports building everything at the same time.

Well, at least it'll be present in the next release with a beta backport.

Rollup merge of rust-lang#95843 - GuillaumeGomez:improve-new-cyclic-d…

Rollup merge of #95843 - GuillaumeGomez:improve-new-cyclic-doc, r=m-o…

Navigation Menu

Repository navigation

{Rc,Arc}::new_cyclic documentation is insufficient #95672

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

{Rc,Arc}::new_cyclic documentation is insufficient #95672

Description

Activity

Aloso commented on Apr 5, 2022

jdahlstrom commented on Apr 5, 2022

CAD97 commented on Apr 5, 2022

jethrogb commented on Apr 5, 2022

emilyalbini commented on Apr 5, 2022

GuillaumeGomez commented on Apr 9, 2022

GuillaumeGomez commented on Apr 9, 2022

emilyalbini commented on Apr 9, 2022

GuillaumeGomez commented on Apr 10, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions