Tracking Issue for MAIN_SEPARATOR_STR #94071

Activity

1. SUPERCILEX

   added

   C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   on Feb 17, 2022
2. kamellperry commented on Aug 25, 2022

   

   kamellperry

   on Aug 25, 2022

   More actions

   What's the status on this?
3. SUPERCILEX commented on Aug 26, 2022

   

   SUPERCILEX

   on Aug 26, 2022

   ContributorAuthor

   More actions

   Probs still waiting on using AsRef.
4. SUPERCILEX commented on Oct 16, 2022

   

   SUPERCILEX

   on Oct 16, 2022

   Last edited by SUPERCILEX

   ContributorAuthor

   More actions

   @yaahc I gave your idea a go, but I don't think it makes sense:

   pub struct Separator;
   
   impl Separator {
       pub const STR: &str = crate::sys::path::MAIN_SEP_STR;
       pub const CHAR: char = crate::sys::path::MAIN_SEP;
   }
   
   impl Deref for Separator {
       type Target = str;
   
       fn deref(&self) -> &Self::Target {
           Self::STR
       }
   }
   
   impl AsRef<str> for Separator {
       fn as_ref(&self) -> &str {
           self
       }
   }
   
   impl AsRef<char> for Separator {
       fn as_ref(&self) -> &char {
           &Self::CHAR
       }
   }

   Hiding the str and char behind a type doesn't really help because the type isn't opaque. People are presumably coming to do low-level stuff with the &str or char so we can't get rid of those constants. Maybe if every API had been designed from the start to take in a Separator this would have made more sense, but as it stands I actually think having a MAIN_SEP_STR constant is perfectly reasonable. At the very least, adding this constant doesn't block any future work (it would just get deprecated/forgotten).

   On that note, how do I start an FCP?
5. JohnTitor

   added 2 commits that reference this issue on Jan 8, 2023

   Rollup merge of rust-lang#103104 - SUPERCILEX:sep-ref, r=dtolnay

   ...

   4aac9b0

   Rollup merge of rust-lang#103104 - SUPERCILEX:sep-ref, r=dtolnay

   ...

   ed77ffe
6. klensy commented on Jan 8, 2023

   

   klensy

   on Jan 8, 2023

   Contributor

   More actions

   In topic: path separator named static when in actually const, but in this example it have possibly no difference.
7. bors

   closed this as completedin ed77ffeon Jan 8, 2023
8. thomcc

   added a commit that references this issue on May 31, 2023

   Rollup merge of #103104 - SUPERCILEX:sep-ref, r=dtolnay

   ...

   c855233