Documentation of Iterator flatten() improvement

While linting my code I came across manual_flatten which was triggered in my code.

This suggests the change from:

for n in x {
    if let Some(n) = n {
        // something here
    }
}

Into:

for n in x.into_iter().flatten() {
    // something here
}

Both are valid code with same result.

But the rust docs on flatten() does not state that this is expected behavior. Yes, this is stated here.
But this was not strait forward (in my opinion) to find. It took me writing a whole bug report and looking a bunch of thing up to figure this out. (and I'm not even new to Rust anymore)

I would suggest adding some example code to make his explicit. Here is a suggestion:
(after the "Mapping and then flattening: <code>...</code>" section)

Flattening also works on other types like Option and Result:

let students_in_seats = vec![Some("Hasan"), Some("Sarah"), None, Some("Tim")];
let students_present: Vec<_> = students_in_seats.into_iter().flatten().collect();
assert_eq!(students_present, vec!["Hasan", "Sarah", "Tim"]);

(or something similar)

This makes both this behavior cleared, easier to find and exposes people to code like this so they are less surprised if clippy starts warning them.

It looks like this behavior might be more common in the future too.
rust-lang/rust-clippy#6061
rust-lang/rust-clippy#6676

@rustbot

@rustbot label T-doc T-libs.

I'm not sure I like clippy's suggestion, personally, but I think your suggested documentation is reasonable. I would also point out that mapping to Option/Result followed by flatten (or a similar flat_map) is better written as filter_map (with ok() for Result).

I was also confused when I saw the suggestion. But once I realizing what is was doing it sounded in line with things like unwrap. That does not mean that I like it, but at least people know it is intended that way and not a side-effect.

@ralpha

I encountered the same clippy warning when iterating over Results, and got perplexed. With the current state of documentation, I personally perceive the warning as suggestion to write obfuscated code hiding the fact that error checking is missing.

Adding the documentation change suggested by @ralpha would make it much easier to realize what flatten() does. Maybe it might be made even more clear how it works if phrasing the first line something like this:

Flattening works on all types implementing Iterator, like Option and Result:

Me too am no longer new to Rust, and thought I had a proficient understanding of flatten() after having used it to unroll nested arrays. Likely I'll not be the last person to be surprised it can also be used to discard Err values.

@rustbot

@rustbot claim

Rollup merge of rust-lang#105034 - HintringerFabian:improve_iterator_…

Navigation Menu

Repository navigation

Documentation of Iterator `flatten()` improvement #82687

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Documentation of Iterator flatten() improvement #82687

Description

Activity

Nicholas-Baron commented on Mar 2, 2021

cuviper commented on Mar 11, 2021

ralpha commented on Mar 11, 2021

nospam3089 commented on Jul 25, 2021

HintringerFabian commented on Nov 28, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Documentation of Iterator `flatten()` improvement #82687