Repository navigation
Diff on rustdoc test failure does not work on Windows #82409
Description
When running x .py test .\src\test\rustdoc on Linux and a failure happens, a really nice diff of the output vs rustdoc-nightly is produced which very clearly shows the issue. This does not work on Windows for multiple reasons.
One the call to diff fails:
info: generating a diff against nightly rustdoc
warning: no pager configured, falling back to `diff --color`
help: try configuring a git pager (e.g. `delta`) with `git config --global core.pager delta`
thread '[rustdoc] rustdoc\sidebar-link-generation.rs' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }', src\tools\compiletest\src\runtest.rs:2467:55Second, the output from rustdoc-nightly seems to exactly match that from the local compiler making it not possible to do manual diffs.
Activity
jyn514 commentedon Feb 22, 2021
How do you diff directories recursively on Windows? On Linux I would be very surprised for
diffnot to be installed.Oh I just thought of something - do you have a rustup overide that defaults to your local toolchain? Right now compiletest assumes the default is nightly, I've been meaning to change it.
rylev commentedon Feb 22, 2021
No, I only set overrides on specific projects (and rust-lang/rust is not one of them). My default is the stable compiler.
mati865 commentedon Feb 23, 2021
Git for Windows provides
diff:Are you building Rust using Git Bash prompt?
rylev commentedon Feb 23, 2021
I don't think it'd be a good idea to require testing rustdoc in the Git for Windows bash shell. I'd like for this to work in cmd.exe and PowerShell if possible.
Rollup merge of rust-lang#82469 - notriddle:bring-our-own-diff, r=Mar…