Skip to content

miri no longer builds after rust-lang/rust#80905 #80907

Description

@rust-highfive

Hello, this is your friendly neighborhood mergebot.
After merging PR #80905, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

Activity

  1. JohnTitor commented on Jan 11, 2021

    @JohnTitor
    Member

    Caused by #80878.

  2. added a commit that references this issue on Jan 11, 2021
  3. RalfJung commented on Jan 15, 2021

    @RalfJung
    Member

    The update could be done any time, it just did not seem to be particularly urgent. ;)

  4. oli-obk commented on Jan 15, 2021

    @oli-obk
    Contributor

    that's an orthogonal issue. We are moving away from submodules, at which points tools will never break again, but it takes a bit of time. Until then, please be mindful of the available time of all the volunteer contributors. If an update is important to you, you can also open a PR doing a bump yourself.

    All the tools are available on beta/stable toolchains, it is only nightly that can have missing tools

  5. RalfJung commented on Jan 15, 2021

    @RalfJung
    Member

    But I think some components being missing from rustup is not good, especially for people like me that use a rust-toolchain file, update it from time to time and gate CI on Miri.

    There's a reason the recommended CI setup for Miri has some magic in it to pick a toolchain that contains Miri. :)

    Yes, I'll do that.

    Thanks! Please r? me in the PR.

  6. added a commit that references this issue on Jan 15, 2021
    bc39d4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-miriArea: The miri toolC-bugCategory: This is a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions