Skip to content

Compilation succeeds even if there is #[inline] in the structure field. #80564

Closed
Closed
Compilation succeeds even if there is #[inline] in the structure field.#80564
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`)C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@Danue1
Danue1
opened on Dec 31, 2020

I tried this code:

struct Foo {
    #[inline]
    bar: String,
}

I expected to see this happen: Failing complilation.

Instead, this happened: Compilation success.

Meta

rustc --version --verbose:

rustc 1.49.0-beta.4 (877c7cbe1 2020-12-10)
binary: rustc
commit-hash: 877c7cbe142a373f93d38a23741dcc3a0a17a2af
commit-date: 2020-12-10
host: x86_64-apple-darwin
release: 1.49.0-beta.4

Activity

  1. Danue1
    added
    C-bugCategory: This is a bug.
    on Dec 31, 2020

  2. ehuss commented on Dec 31, 2020

    @ehuss
    ehuss
    on Dec 31, 2020
    Contributor

    Some validation was added in #73461, but it looks like there are a few places that are missing. The ones I can see are struct fields, match arms, and macro definitions:

    struct Foo {
    #[inline]
    bar: String,
}

match foo {
    #[inline]
    _ => {}
}

#[inline]
macro_rules! foo {
    () => {};
}

    I believe that CheckAttrVisitor needs to include visitor methods for visit_arm and visit_struct_field and visit_macro_def.

  3. camelid
    added
    A-attributesArea: Attributes (`#[…]`, `#![…]`)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 1, 2021

  4. Danue1 commented on Jan 2, 2021

    @Danue1
    Danue1
    on Jan 2, 2021
    ContributorAuthor

    Hmm, I think I can do it, so I'll try it.

  5. bors
    added a commit that references this issue on Feb 1, 2021

    Auto merge of rust-lang#80641 - Danue1:patch-1, r=oli-obk

    d4e3570

  6. Danue1 commented on Feb 2, 2021

    @Danue1
    Danue1
    on Feb 2, 2021
    ContributorAuthor

    solved!

  7. Danue1
    closed this as completedon Feb 2, 2021
  8. github-actions
    added a commit that references this issue on May 10, 2022

    ices/95151.rs: fixed with no errors

    b5c30fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-attributesArea: Attributes (`#[…]`, `#![…]`)C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions