Skip to content

MIR body serialization may be a bottleneck #80536

Description

@oli-obk

During MIR inlining, we end up producing larger MIR bodies each, as inlining often causes an increase in MIR for non-trivial functions being inlined. This perf run shows that in the incremental cases, we lose some time to optimized_mir as expected but this is often offset by wins in codegen.

However the other place we regress is time spent dealing with the incremental cache. That suggests to me that our MIR is larger due to inlining which causes more time to be spent during serialization/deserialization.

It might be worth exploring if there's any optimizations we can make to the serialized Body representation.

Originally posted by @wesleywiser in #68828 (comment)

Activity

  1. added
    I-compiletimeIssue: Problems and improvements with respect to compile times.
    A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
    on Jan 1, 2021
  2. tmiasko commented on Mar 14, 2021

    @tmiasko
    Contributor

    Decoding of foreign spans is one of hotspots quite unique to builds with inlining:

    // Decoding 'foreign' spans should be rare enough that it's
    // not worth it to maintain a per-CrateNum cache for `last_source_file_index`.
    // We just set it to 0, to ensure that we don't try to access something out
    // of bounds for our initial 'guess'
    decoder.last_source_file_index = 0;
    let foreign_data = decoder.cdata().cstore.get_crate_data(cnum);
    foreign_data.imported_source_files(sess)

  3. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Apr 5, 2023
  4. added
    C-optimizationCategory: An issue highlighting optimization opportunities or PRs implementing such
    on Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlA-incr-compArea: Incremental compilationA-metadataArea: Crate metadataA-mir-optArea: MIR optimizationsA-mir-opt-inliningArea: MIR inliningC-optimizationCategory: An issue highlighting optimization opportunities or PRs implementing suchI-compiletimeIssue: Problems and improvements with respect to compile times.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions