Skip to content

asm! should catch attempts to use .intel_syntax or .att_syntax and suggest appropriate options instead #79869

Closed
#82270
Closed
asm! should catch attempts to use .intel_syntax or .att_syntax and suggest appropriate options instead#79869
#82270
Assignees
asquared31415
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsA-inline-assemblyArea: Inline assembly (`asm!(…)`)C-enhancementCategory: An issue proposing an enhancement or a PR with one.F-asm`#![feature(asm)]` (not `llvm_asm`)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@joshtriplett
joshtriplett
opened on Dec 9, 2020

People used to gcc/clang inline assembly may try using the .intel_syntax or .att_syntax directives directly in the assembly string, which can cause issues. Ideally, we should detect attempts to use those directives. Attempting to use .intel_syntax should generate an error stating that that's the default. Attempting to use .att_syntax should generate an error and point to the att_syntax option, ideally with a rustfix-applicable suggestion.

Activity

  1. joshtriplett
    added
    A-diagnosticsArea: Messages for errors, warnings, and lints
    A-inline-assemblyArea: Inline assembly (`asm!(…)`)
    F-asm`#![feature(asm)]` (not `llvm_asm`)
    on Dec 9, 2020
  2. joshtriplett
    assigned
    Amanieu
    on Dec 9, 2020
  3. camelid
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Dec 9, 2020

  4. asquared31415 commented on Feb 17, 2021

    @asquared31415
    asquared31415
    on Feb 17, 2021
    Contributor

    Is anyone currently working on this? I would like to do it if not.

  5. joshtriplett commented on Feb 17, 2021

    @joshtriplett
    joshtriplett
    on Feb 17, 2021
    MemberAuthor

    @asquared31415 Not to my knowledge, no.

  6. asquared31415 commented on Feb 17, 2021

    @asquared31415
    asquared31415
    on Feb 17, 2021
    Contributor

    @rustbot claim

  7. rustbot
    assigned
    asquared31415
    and unassigned
    Amanieu
    on Feb 17, 2021
  8. Dylan-DPC-zz
    added a commit that references this issue on Mar 17, 2021

    Rollup merge of rust-lang#82270 - asquared31415:asm-syntax-directive-…

    16f6583
  9. bors
    closed this as completedin 16f6583on Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-diagnosticsArea: Messages for errors, warnings, and lintsA-inline-assemblyArea: Inline assembly (`asm!(…)`)C-enhancementCategory: An issue proposing an enhancement or a PR with one.F-asm`#![feature(asm)]` (not `llvm_asm`)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions