Repository navigation
Remove log renamings of tracing crate #74747
Description
In #74726 I made a dependency import hack to reduce the diff size. We should replace all of these imports with tracing = "0.1" and then adjust the crate source by replacing all uses of log imports with tracing import.
Ideally only a few of these are done at a time to keep conflicts at a minimum and get such PRs merged fast.
Note: do not start working on this until #74726 is merged.
- librustc_ast
- librustc_ast_lowering
- librustc_ast_passes
- librustc_ast_pretty
- librustc_builtin_macros
- librustc_codegen_llvm
- librustc_codegen_ssa
- librustc_data_structures
- librustc_driver
- librustc_errors
- librustc_expand
- librustc_hir
- librustc_incremental
- librustc_infer
- librustc_interface
- librustc_lint
- librustc_metadata
- librustc_middle
- librustc_mir
- librustc_mir_build
- librustc_parse
- librustc_passes
- librustc_privacy
- librustc_query_system
- librustc_resolve
- librustc_save_analysis
- librustc_session
- librustc_span
- librustc_symbol_mangling
- librustc_target
- librustc_trait_selection
- librustc_traits
- librustc_ty
- librustc_typeck
- compiletest
- librustdoc
Activity
[-]Remove from `log` renaming of `tracing` crate[/-][+]Remove `log` renamings of `tracing` crate[/+]bishtpawan commentedon Jul 26, 2020
Hi @oli-obk I saw your PR of (#74726 ) where you have replaced
log="0.4"tolog = { package = "tracing", version = "0.1" }and in this issue, you have mentioned like we have to replace all log imports to tracing imports. My question here is when you have already changed the package fromlogtotracingso now what left in it because the import name cannot be changed in files if we have usedlogas a crate name in Cargo.toml?Do we need to replace the name of dependency from
logtotracingthen we'll clean up the code by replacing the log imports with tracing imports in the corresponding files? Or is there anything else you want?Thanks,
Waiting for your response.
oli-obk commentedon Jul 26, 2020
Yes, that's exactly it. Replace
log = { package = "tracing", version = "0.1" }withtracing = "0.1"and then fix up the errors by changing the import names. Note that the PR isn't merged yet, so this issue is not yet actionable.bishtpawan commentedon Jul 26, 2020
Thanks for the response. Yes, I'm waiting for your PR to be merged first.
georgio commentedon Jul 31, 2020
I would like to give this a shot when #74726 is merged
oli-obk commentedon Jul 31, 2020
Once the PR is merged, before you work on anything, please post here which libs you are going to work on so that you don't conflict with others who are doing the same
pawanbisht62 commentedon Aug 1, 2020
As they are independent, we can make changes on multiple files right? If yes then I'll work on following libs
After that will pick new libs accordingly if we will left with some.
Thanks
gdhuper commentedon Aug 2, 2020
If no one else is planning on tackling the following:
I would like to take a stab. Thanks
georgio commentedon Aug 2, 2020
I could take care of the remaining files:
Rollup merge of rust-lang#75041 - pawanbisht62:feature/replace-log-wi…
georgio commentedon Aug 4, 2020
Hey everyone, I would like to apologize for not being able to carry this through at the moment. My country was rocked by a massive explosion and I have to be on the ground to help. I wouldn't mind getting back to this as soon as things calm down a bit but if you're short on time I would suggest that someone else takes care of my part of the issue.
gdhuper commentedon Aug 4, 2020
Hey @georgio, so sorry to hear that. I can take care of the rest.
georgio commentedon Aug 5, 2020
@gdhuper thank you very much. I really appreciate it.
CloudNClock commentedon Aug 5, 2020
I will take care of
librustdoc, then every task is claimed if I am not mistaken.Stay safe.
It seems
librustdochas been updated already.Auto merge of rust-lang#75514 - gdhuper:gdhuper/replace_log_with_trac…
pawanbisht62 commentedon Aug 16, 2020
@bors can you please look at the PR #75187 as it is related to this issue and still in open state. Thanks
oli-obk commentedon Aug 17, 2020
@pawanbisht62
borsis a bot, You can just post messages like the one you did in this issue without pinging it. We just need to ping it when giving it commands to merge PRsAuto merge of rust-lang#75187 - pawanbisht62:feature/incorporate-trac…
oli-obk commentedon Aug 26, 2020
I think we solved all of these