const generic inference variables not properly tracked by traits/fulfill.

@nikomatsakis

I've come up with this example (playground):

#![feature(const_generics)]

fn works() {
    let array/*: [_; _]*/ = default_array();
    let _: [_; 4] = array;
    Foo::foo(&array);
}

fn doesnt_work() {
    let array/*: [_; _]*/ = default_array();
    // ^ cannot infer type for type parameter `T` declared on the function `default_array`
    Foo::foo(&array);
    let _: [_; 4] = array;
}

trait Foo {
    fn foo(&self) {}
}

impl Foo for [i32; 4] {}
impl Foo for [i64; 8] {}

// Only needed because `[_; _]` is not valid type syntax.
fn default_array<T, const N: usize>() -> [T; N]
    where [T; N]: Default,
{
    Default::default()
}

My understanding is that the error is caused by the [$T; $C]: Foo obligation being stalled_on on just $T (which means it's not retried when $C is unified with 4), whereas it should be stalled on both $T and $C so that it's retried when either changes.

Right now stalled_on is limited to type inference variables, so its representation will need to change, and Ty::walk will need to expose constants too.

I believe #70107 ran into this as well, but for WF obligations, not trait ones.

I'm self-assigning this because I'm working on the fix (as part of a larger effort).

cc @nikomatsakis @varkor @yodaldevoid

Note to self: the PR fixing this should also test this example (playground):

#![feature(const_generics)]

fn works() {
    let array/*: [u8; _]*/ = default_byte_array();
    let _: [_; 4] = array;
    Foo::foo(&array);
}

fn doesnt_work() {
    let array/*: [u8; _]*/ = default_byte_array();
    Foo::foo(&array);
    // ^ cannot infer type for type parameter `T` declared on the trait `Foo`
    let _: [_; 4] = array;
}

trait Foo<T> {
    fn foo(&self) {}
}

impl Foo<i32> for [u8; 4] {}
impl Foo<i64> for [u8; 8] {}

// Only needed because `[u8; _]` is not valid type syntax.
fn default_byte_array<const N: usize>() -> [u8; N]
    where [u8; N]: Default,
{
    Default::default()
}

The reason for this is that this second example has the type and const inference variables in different generic args of Foo, meaning fixing it also requires changing this to has_infer_types_or_consts:

rust/src/librustc_trait_selection/traits/fulfill.rs

Line 545 in f4c675c

.filter(|t| t.has_infer_types())

I've definitely noticed problems with inference involving consts before, but wasn't able to pin down where the issue was stemming from. It would be great if this could be addressed once and for all.

Rollup merge of rust-lang#70213 - eddyb:stalled-on-ty-or-const, r=nik…

Rollup merge of rust-lang#72061 - lcnr:const-inference-test, r=eddyb

Navigation Menu

Repository navigation

const generic inference variables not properly tracked by traits/fulfill. #70180

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

const generic inference variables not properly tracked by traits/fulfill. #70180

Description

Activity

eddyb commented on Mar 20, 2020

varkor commented on Mar 20, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions