Repository navigation
Suggest removing &mut x when x: &mut T and &mut T is expected type #68697
Description
An example:
struct A;
fn bar(x: &mut A) {}
fn foo(x: &mut A) {
bar(&mut x);
}results in:
error[E0596]: cannot borrow `x` as mutable, as it is not declared as mutable
--> src/lib.rs:6:9
|
5 | fn foo(x: &mut A) {
| - help: consider changing this to be mutable: `mut x`
6 | bar(&mut x);
| ^^^^^^ cannot borrow as mutablebut we could say:
error[E0596]: cannot borrow `x` as mutable, as it is not declared as mutable
--> src/lib.rs:6:9
|
5 | fn foo(x: &mut A) {
6 | bar(&mut x);
| ^^^^^^ cannot borrow as mutable
| ---- help: remove the unnecessary `&mut` hereMetadata
Metadata
Assignees
Labels
Area: The borrow checkerArea: Messages for errors, warnings, and lintsArea: Type systemCategory: An issue proposing an enhancement or a PR with one.Diagnostics: A diagnostic that is giving misleading or incorrect information.Relevant to the compiler team, which will review and decide on the PR/issue.
Activity
LeSeulArtichaut commentedon Jan 31, 2020
I’d be interested in working on this. I’ll probably take a look in the next few days.
LeSeulArtichaut commentedon Feb 1, 2020
@rustbot claim
LeSeulArtichaut commentedon Feb 2, 2020
Looks like this is a regression, see 3303e68
LeSeulArtichaut commentedon Feb 11, 2020
@rustbot release-assignment
ibraheemdev commentedon Jul 25, 2021
I think this issue was fixed:
ibraheemdev commentedon Jul 25, 2021
Actually, that should be a help message. @rustbot claim
Rollup merge of rust-lang#87453 - ibraheemdev:i-68697, r=wesleywiser
Rollup merge of rust-lang#87453 - ibraheemdev:i-68697, r=wesleywiser