Skip to content

rls no longer builds after rust-lang/rust#65076 #65084

Description

@rust-highfive

Hello, this is your friendly neighborhood mergebot.
After merging PR #65076, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @tmandry, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @tmandry, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Oct 4, 2019
  2. tmandry commented on Oct 5, 2019

    @tmandry
    Member

    rustfmt was broken by #64690 so I'd start with looking at that.

  3. topecongiro commented on Oct 7, 2019

    @topecongiro
    Contributor

    @Xanewok I have just released rustfmt 1.4.9. racer has been fixed as well (cc racer-rust/racer#1076), but the fix is not published yet.

  4. pnkfelix commented on Oct 10, 2019

    @pnkfelix
    Contributor

    visiting for triage: P-high, removing nomination label.

  5. kngwyu commented on Oct 11, 2019

    @kngwyu
    Contributor

    @Xanewok
    I also released racer 2.1.28.
    It's ready to update RLS.

  6. Xanewok commented on Oct 11, 2019

    @Xanewok
    Contributor

    Great, thanks! I’ll update this today.

  7. ghedo commented on Oct 11, 2019

    @ghedo
    Contributor

    @Xanewok ah, missed your comment, so I created rust-lang/rls#1563 just now. Hope that's ok.

  8. Xanewok commented on Oct 11, 2019

    @Xanewok
    Contributor

    The RLS dep bump has landed, so now we need to open a PR with an update to both RLS and Rustfmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P-highHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions